Duplicate Optimize Attachments failing on .pdf

[cdarsch]

Affected version

2.3.6

I ran Optimize Attachments and got the following error:

• ErrorException: [E_WARNING] imagewebp(): gd-webp encoding failed
• src/XF/Image/Gd.php:224
• Generated by: Christo
• Feb 25, 2025 at 10:31 AM

Stack trace​

#0 [internal function]: XF::handlePhpError(2, '[E_WARNING] ima...', '/home/gmcrvfor/...', 224)
#1 src/XF/Image/Gd.php(224): imagewebp(Object(GdImage), '/home/gmcrvfor/...', 85)
#2 src/XF/Image/AbstractDriver.php(285): XF\Image\Gd->_optimizeImage('/home/gmcrvfor/...', 85)
#3 src/XF/Service/Attachment/PreparerService.php(183): XF\Image\AbstractDriver->optimizeImage('/home/gmcrvfor/...')
#4 src/addons/XFMG/XF/Service/Attachment/Preparer.php(13): XF\Service\Attachment\PreparerService->optimizeExistingAttachment(Object(SV\AttachmentImprovements\XF\Entity\AttachmentData))
#5 src/addons/SV/AttachmentImprovements/XF/Service/Attachment/Preparer.php(134): XFMG\XF\Service\Attachment\Preparer->optimizeExistingAttachment(Object(SV\AttachmentImprovements\XF\Entity\AttachmentData))
#6 src/XF/Job/AttachmentOptimization.php(33): SV\AttachmentImprovements\XF\Service\Attachment\Preparer->optimizeExistingAttachment(Object(SV\AttachmentImprovements\XF\Entity\AttachmentData))
#7 src/XF/Job/AbstractImageOptimizationJob.php(27): XF\Job\AttachmentOptimization->optimizeById(1372)
#8 src/XF/Job/AbstractRebuildJob.php(42): XF\Job\AbstractImageOptimizationJob->rebuildById(1372)
#9 src/XF/Job/AbstractImageOptimizationJob.php(18): XF\Job\AbstractRebuildJob->run(8)
#10 src/XF/Job/Manager.php(275): XF\Job\AbstractImageOptimizationJob->run(8)
#11 src/XF/Job/Manager.php(205): XF\Job\Manager->runJobInternal(Array, 8)
#12 src/XF/Job/Manager.php(121): XF\Job\Manager->runJobEntry(Array, 8)
#13 src/XF/Admin/Controller/ToolsController.php(146): XF\Job\Manager->runByIds(Array, 8)
#14 src/XF/Mvc/Dispatcher.php(362): XF\Admin\Controller\ToolsController->actionRunJob(Object(XF\Mvc\ParameterBag))
#15 src/XF/Mvc/Dispatcher.php(264): XF\Mvc\Dispatcher->dispatchClass('XF:Tools', 'RunJob', Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\ToolsController), NULL)
#16 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Admin\Controller\ToolsController), NULL)
#17 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#18 src/XF/App.php(2826): XF\Mvc\Dispatcher->run()
#19 src/XF.php(806): XF\App->run()
#20 admin.php(15): XF::runApp('XF\\Admin\\App')
#21 {main}

Request state​

array(4) {
["url"] => string(24) "/admin.php?tools/run-job"
["referrer"] => string(124) "https://www.gmcmotorhome.org/admin.php?tools/run-job&only_id=190583&_xfRedirect=/admin.php?tools/rebuild&success=1"
["_GET"] => array(1) {
["tools/run-job"] => string(0) ""
}
["_POST"] => array(3) {
["_xfRedirect"] => string(62) "https://www.gmcmotorhome.org/admin.php?tools/rebuild&success=1"
["_xfToken"] => string(8) "********"
["only_ids"] => string(6) "190583"
}
}

I then performed the following SQL query:

SELECT data_id
FROM xf_attachment_data
WHERE optimized = 0
ORDER BY data_id
LIMIT 1;

and when I looked at the row in the xf_attachment_data table that this query returned, the filename was xxxx.pdf.

Optimize Attachments should skip PDF files.

Discussion that led to this discovery: https://xenforo.com/community/threads/optimize-attachments-failure.229465/page-2#post-1735389

 

[briansol]

I would take it a step further and say not just pdf files, but all non-image files.

I have zip, mp3, wav, etc that all fail too

 

[Digital Doctor]

is this a chunked uploads issue ?

 

[cdarsch]

is this a chunked uploads issue ?

Not sure I understand your question.

 

[Digital Doctor]

Not sure I understand your question.

Chunked Uploads is new

XF 2.4 Thread 'Chunked uploads'

Feb 7, 2025

Welcome back to our Have you seen...? series for XenForo 2.4! The code reviews are coming in thick and fast as we complete our planned features so there should be plenty to show you over the coming weeks.

Part of our process for this and previous releases has involved looking at the amazing pool of developer talent that we have in this community and considering how we can work with those developers to bring those features to the core.

And that's the focus of this time where we'll be taking a look at the Chunked Uploads add-on by @JulianD which, starting with...

• Chris D
• Replies: 63
• Forum: Have you seen...?

• 
• 

might be related to that if the issue is new.

 

[M@rc]

might be related to that if the issue is new.

XF 2.4 isn't out btw.

 

[Digital Doctor]

XF 2.4 isn't out btw.

so it won't be that then
thanks for pointing it out.
sorry, carry on.

at the same time, maybe chunked uploads is a SOLUTION to this issue

 

[cdarsch]

so it won't be that then
thanks for pointing it out.
sorry, carry on.

at the same time, maybe chunked uploads is a SOLUTION to this issue

The problem I'm having is with the bulk conversion of existing images into webp format via Tools/Rebuild/Caches/Optimize Attachments, not with the upload/conversion of new images.

 

[Jeremy P]

There won't be any attempt to do image optimization on non-image attachments. The attachment data column being 0 reflects nothing other than the attachment was not optimized (because it was not an image).

The error message you're running into likely just bad error handling around libwebp in certain PHP versions. What PHP version are you running?

 

[cdarsch]

Hi Jeremy P! I'm running PHP 8.3.16. I'm not expecting image optimization on non-image attachments, but I do expect the procedure to skip non-image attachments without failing.

 

[Jeremy P]

It already does (unless there are other inconsistencies in your database, but then you have bigger problems). This error will almost certainly be from it failing on a genuine image due to an encoding/decoding error in libwebp. I don't believe PHP provides us much of a way to handle this more gracefully yet, unfortunately.

I've revised my query slightly in the previous instructions I gave, if you wish to try to resolve it manually:

Confirmed Post in thread 'Image optimisation fails with gd-webp encoding failed'

Nov 11, 2024

And the error is a warning (E_WARNING), rather than a fatal error? You might want to try using Imagick instead. Otherwise you can try marking the problem file as optimized manually, and then running the tool again.

SELECT data_id
FROM xf_attachment_data
WHERE optimized = 0
AND width > 0
ORDER BY data_id
LIMIT 1;

UPDATE xf_attachment_data
SET optimized = 1
WHERE data_id = 123; -- replace 123 with the data_id from the query above

• Jeremy P

 

[cdarsch]

That enabled the process to bypass the problem image. Thank you!

However, upon investigating, the problem image is a panoramic photo with dimensions 12,368 x 3,776. The forum can display the image fine. This is still a bug, no?

 

[Jeremy P]

Yes, but our options for dealing with it may be limited a bit. It’s being tracked in the linked bug report. The information you’ve provided is helpful though, maybe we can skip over images above a certain dimensional threshold for now.