As designed Opening contact us as overlay does not always work

Kirby

Well-known member
Affected version
2.0.6 Beta 2
Description
I've configure a custom URL for contact us and enabled Open this link in an overlay

Expected Result
When viewing the privacy policy all links to contact use the new URL and open in an overlay

Actual Result
When viewing the privacy policy all links to contact use the new URL but do not open in an overlay
 
This is mostly expected. The overlay option really only guarantees that launching it from the footer link will open it in an overlay. There's also a design issue aspect here in that we can't pass conditional options into phrases.

If it's something you want to ensure opens in an overlay then when translating the phrase you can just add data-xf-click="overlay" to the contact links.
 
Actually I don't care at all if those links open in an overlay or not, I just stumbled over the phrase issue and thought it might be worth reporting it (altough I expected it's working as designed).

Thanks for the reply :)
 
Top Bottom