Fixed Node "sub-type" icons not always being used

[digitalpoint]

Affected version

2.2.12

Minor, but... If you look at the Node list in the admin area, you see something like this:



You get the icons that are specific to the ForumType handler (for example the Question forum type gives the question-mark icon as well as the text showing what type of forum it is).

If you look at the Node permissions page, you lose a lot of that info... everything reverts to default info for the Forum (you don't see the text or icons).



Shouldn't this be showing info from the ForumType handler?

In the admin:permission_node_overview template, if you change this:

<xf:cell class="dataList-cell--min"><i class="nodeIcon nodeIcon--{$node.NodeType.node_type_id}"></i></xf:cell>

...to this:

<xf:cell class="dataList-cell--min"><xf:macro template="node_list" name="node_icon" arg-node="{$node}" /></xf:cell>

...and...

<div class="dataList-mainRow">{$node.title} <span class="dataList-hint" dir="auto">{$node.NodeType.title}</span></div>

...to this:

<div class="dataList-mainRow">{$node.title} <span class="dataList-hint" dir="auto">{$node.NodeType.title} <xf:if is="callable($node.Data, 'getTypeHandler')"> ({{ $node.Data.TypeHandler.getTypeTitle() }})</xf:if></span></div>

Then you are presented with something that makes more sense and is more consistent with the Node list:

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.13).

Change log:

Add context to node permission list with node type icons.

There may be a delay before changes are rolled out to the XenForo Community.