Fixed New Chrome Bug - scroll limited for custom fields

[cdub]

Affected version

2.3.6

I just ran into this strange issue with a custom field with multiple pulldown options for choice fields. I have one cusom field that has a TON of options and recently some users have been reporting that they can't scroll past a certain point to select their option. It always worked for me just fine but for the first time ever I was able to see what my users were seeing on Chrome for Android:



I haven't changed much with this custom field except for adding another option. Works completely fine on Chrome of MacOS for me although a member of my site said they have a similar issue on Chrome Mac OS.

To test it go to thie page and choose the film program pulldown. You should be able to scroll all the way to the bottom to where it says PLEASE ADD MY PROGRAM.

Add Application

www.filmschool.org

For some reason on Chrome Android I cannot - Chrome MacOS works fine. Very strange.



This is a custom field with @Bob 's showcase addon but custom fields are custom fields right? Has anyone else run into this. Is anyone else having the same problem when doing the Film Program & Degree pulldown? Very strange.

 

[cdub]

Apparently it's an issue with Chrome 134.0.6998.89, desktop

I'm on 133.0.6943.55 (Official Build) (arm64) and I have no issues.

 

[cdub]

Just updated to the same version of Chrome and I was able to reproduce the error. Safari works fine.

 

[cdub]

Just updated to the same version of Chrome and I was able to reproduce the error. Safari works fine.

This is as far as I can scroll with Version 134.0.6998.89 (Official Build) (arm64)



Safari works fine:

 

[Jeremy P]

This is likely a bug stemming from recent changes to select handling in Chrome v134: https://developer.chrome.com/release-notes/134#html_and_dom

It's unlikely we can do much to work around it, but usually regressions like this are fixed before too long. You might try subscribing to an origin trial to revert the changes in the meantime: https://developer.chrome.com/origintrials/#/view_trial/182958734861926401

 

[Jeremy P]

In looking further into this, it appears it may be related to an odd option name or value. Do any names or values contain an angled bracket (ie. <mfa or similar)?

 

[cdub]

In looking further into this, it appears it may be related to an odd option name or value. Do any names or values contain an angled bracket (ie. <mfa or similar)?

That was it! Thank you!

 

[Jeremy P]

We'll probably make changes to escape the labels here in a future release, which should resolve this properly.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.7).

Change log:

Escape select input option labels

There may be a delay before changes are rolled out to the XenForo Community.

 

[Xon]

We'll probably make changes to escape the labels here in a future release, which should resolve this properly.

One workaround would be to use the label attribute with for_attr escaping instead of raw html in the <option>...</option> tag itself

 

[Jeremy P]

We just escape the label in the templater, and avoid double escaping any HTML entities. No template changes are required.