Modify push notification time

[rdn]

XenForo reduces the default timeout of the Web Push library from 30 to 10 seconds.

I would like to prevent the 10 seconds delay for some users, is it possible I can lower this down to 3 seconds?
Which file to modify?

Thanks.

 

[Steffen]

Have a look at \XF\Service\PushNotification.php::getWebPushObject and modify the 10.

 

[rdn]

Thanks, I assume this is correct:

 

[Steffen]

Yes, that should reduce the timeout to 3 seconds. You will probably see more "Push notification failure" server errors in your admin panel after this change because timeouts are now more likely to occur.

 

[rdn]

Is it also possible to NOT log the timeout errors?
This isn't that much important anyway.

 

[Steffen]

This should do the trick:

--- src/XF/Service/PushNotification.php
+++ src/XF/Service/PushNotification.php
@@ -250,6 +250,10 @@ class PushNotification extends AbstractService
                             break;
                     }
                 }
+                else if (isset($result['message']) && strpos($result['message'], 'cURL error 28') === 0)
+                {
+                    // ignore timeout errors
+                }
                 else
                 {
                     \XF::logError("Push notification failure: " . \GuzzleHttp\json_encode($result));

 

[rdn]

I'm not sure though on which line should I add that code .

else if (isset($result['message']) && strpos($result['message'], 'cURL error 28') === 0)
                {
                    // ignore timeout errors
                }

 

[rdn]

Only similar code is this, but not exactly the same as yours.

 

[Paul B]

What @Steffen posted is from 2.1.

It will need adapting to work for 2.2 as it doesn't use $result in the code.

 

[rdn]

You will probably see more "Push notification failure" server errors in your admin panel after this change because timeouts are now more likely to occur.

I even changed it to 2, but still only few errors pop out.

2 seconds max response from google/firefox push servers is fine I think versus long delay for some forum activity like post reply.