Closed Missing globally cached phrases

[Painbaker]

Affected version

2.3.13

Some commonly used in PHP code phrases are missing from the global phrase cache and cause unnecessary database queries

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('public', 'email', 'admin')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('x_days_ago')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('block', 'scrolling', 'floating', 'fixed')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('all')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('status_update_by_x')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('public', 'email', 'admin')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('permanent_link')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('viewing_members', 'viewing_member_profile')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('xfmg_view_media_item_x')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('requested_page_not_found')

SELECT title, phrase_text
FROM xf_phrase_compiled
WHERE language_id = ?
    AND title IN ('1_day_ago', '1_week_ago', '2_weeks_ago', '1_month_ago', '3_months_ago', '6_months_ago', '9_months_ago', '1_year_ago', '2_years_ago')

post_date
comments
reaction_score
post_noun
thread
permanent_link
all
x_days_ago

 

[XF Bug Bot]

Automated triage: As designed

Phrases used only on particular pages, mostly in the admin control panel, are loaded when needed rather than cached globally, which keeps the global cache small. One of the listed phrases comes from an add-on, not XenForo itself.

In XenForo 2.4, phrases are compiled to PHP files and no longer loaded from the database, so these queries go away entirely.

This is an automated assessment. A member of staff may review and update it.