Lack of interest [minor] Use array_unique() in XenForo_Model_Import::getImportContentMap()

This suggestion has been closed automatically because it did not receive enough votes over an extended period of time. If you wish to see this, please search for an open suggestion and, if you don't find any, post a new one.
Mike Tougeron

Mike Tougeron

Well-known member
When importing extremely large datasets, the query created in XenForo_Model_Import::getImportContentMap() can get very large and run out of memory. This method doesn't check to see if the $ids is an array with only unique values so the IN statement could include 1000s of values when only a few 100 are needed.

Line 311
$ids = array_unique($ids);

I know this is a minor thing and won't happen that often for most people but I thought I'd throw it out there since it caused me some minor headaches. :)

Thanks, Mike
 
Upvote 0
This suggestion has been closed. Votes are no longer accepted.
Top Bottom