R
ragtek
Guest
You have the same method in 2 modesl (conversation & thread)
If a add-on coder wants to implement this for his add-on, he needs to add this in his model too, or to extend his model from one of the two models^^.
Wouldn't it be better to move it to xenforo_model so everybody could use it?
BUT, do you really need this?
If you would move add the "return false" part to XenForo_Helper_Discussion::getLastPageNumbers, the whole method would be IMHO unnecessary.
If a add-on coder wants to implement this for his add-on, he needs to add this in his model too, or to extend his model from one of the two models^^.
Wouldn't it be better to move it to xenforo_model so everybody could use it?
BUT, do you really need this?
If you would move add the "return false" part to XenForo_Helper_Discussion::getLastPageNumbers, the whole method would be IMHO unnecessary.
Upvote
0
