Fixed Lift Ban popping open User Profile

[b94]

Affected version

2.3.6

While testing 2.3.6 (but this seems to even happen in much older versions) a moderator reported that the "Lift Ban" feature from a user's profile was popping open the user's profile popup, with no lift of the ban or further ban prompts occurring. This seemed to be happening on all of our moderator roles.

It appears that the lift ban button links to a url like /members/{id}/ban/lift which when opened in a new tab also redirects to the user's profile, but in the form members/{name}.{id}/

If I instead go to members/{name}.{id}/ban/lift manually, I can view the correct confirmation form for lifting a ban.

What could be causing this, and is it an XF bug?

 

[b94]

It appears this can be fixed by changing this part of the template member_ban_edit:

<xf:button href="{{ link('members/ban/lift', $userBan) }}" overlay="true">

To this:

<xf:button href="{{ link('members/ban/lift', $user) }}" overlay="true">

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.7).

Change log:

Fix lift ban link on ban edit page

There may be a delay before changes are rolled out to the XenForo Community.