XF 2.1 Is this how I should handle permissions?

[AndrewSimm]

This is in my controller

        $visitor = \XF::visitor();

        if (!$visitor->hasPermission('andrew_articles', 'canCreateEditArticle')) {

            throw $this->exception($this->noPermission());

        }

        if ($visitor->hasPermission('andrew_articles', 'canCreateEditArticle')) {
            
            blah blah create article

        }

 

[Z61]

The second check is unnecessary if you're using the first.

 

[Lukas W.]

return $this->noPermission();

Is enough. No need to throw an exception, it's not a code error.

 

[AndrewSimm]

Is enough. No need to throw an exception, it's not a code error.

Thanks Lukas!