XF 2.2 Is this an error in Entity/User.php?

[Neilski]

I was just exploring the code to check the impact of is_staff, and came across some oddly-worded code which makes me suspect an error in the canEdit() function:

                if ($this->is_admin && $this->is_moderator && $this->is_staff)
                {
                        // moderators can't edit admins/mods/staff
                        return false;
                }

If I'm interpreting the comment correctly, the routine should return false if any of the flags are true, but it's ANDing them instead of ORing them.

 

[Jeremy P]

Good catch. I've sorted this for future releases.