XF 2.2 Image Proxy

[alexm]

Hi,

I noticed a problem with the image proxy today on XF 2.2.8. Some images that are marked with a cross actually do have images next to it and if I find one in my log it loads fine, but the post just has a red X.





It says it hasn't been accessed since Tuesday despite me trying to access it now and it refuses to load a fresh image despite me selecting 1 day. I tried to delete the log down to a single day as well but it has only deleted up to Monday and one on Sept 13th.





Is there a way I can totally wipe the proxy (database tables and files) and start again? Or otherwise fix whatever it is that is wrong.

thanks,

Alex

 

[alexm]

Can I just empty xf_image_proxy and xf_image_proxy_referrer and delete .../internal_data/image_cache/*? Or is there more to it?

 

[Paul B]

What is returned if you enter one of the image URLs into the image proxy test?

 

[alexm]

It says "was fetched successfully."

 

[Paul B]

What do you have set for these options?

 

[alexm]

I did have it set as:

Image cache lifetime: 5 days
Image cache refresh: 0 days
Image cache max size: 5120 KB


When I tried to delete the log I had:

Image cache lifetime: 1 days
Image cache refresh: 0 and 1 days
Image cache max size: 5120 KB

I ran the hourly cleanup to run the log delete.

1 of these images as an example, still is preset and won't update either:

 

[Paul B]

I have the same issue on my own site and I've never been able to resolve it.

It seems that once a proxy image fails for whatever reason, there is no way to force a refresh of it, even though the option descriptions suggest it should happen automatically when the image is requested again , e.g. by viewing the post.

 

[alexm]

Can I just empty xf_image_proxy and xf_image_proxy_referrer and delete .../internal_data/image_cache/*? Or is there more to it?

If I do this, will anything break?

 

[PASS]

I'm having the same issue. The image shows broken but when you edit the post it will show. Then it will be broken again after saving the edit.

 

[Paul B]

The editor doesn't use the proxy which is why it shows.

I don't have a solution - I can't get failed images to be refetched and show.

 

[PASS]

The editor doesn't use the proxy which is why it shows.

I don't have a solution - I can't get failed images to be refetched and show.

I have hundreds of broken images. Not sure if it was due to upgrading to 2.2.8. I got a few messages asking if I changed anything as members are noticing their images are broken and the only thing was the upgrade the other day was to 2.2.8. Hopefully it will get sorted and it can be fixed.

 

[alexm]

can't get failed images to be refetched and show.

And it can't be deleted either!

It's like the routine that reads posts recognises the saved image, but the routine that resizes log/re-fetches image etc. sometimes doesn't. And it's fine up until a point, then it no longer recongises it has it in the database.

 

[PASS]

I wonder if this has something to do with it. The issue started after updating to 2.2.8.

Fixed - Image Proxy refresh seems inefficient

When refreshing a proxied image, XF\Service\ImageProxy::finalizeFromFetchResults() always does write the image file on success even if nothing has changed. This does seem inefficient as it does cause more writes than necessary which could be an issue when using short refresh times and SSDs...

xenforo.com

 

[Kirby]

Yes, it is caused by this change.

Fixed - Pruning proxied images does not reset file hash

When proxied images are being pruned after exipiry by calling \XF\Entity\ImageCache::prune(), their file_hash does not get reset. Due to the change in https://xenforo.com/community/threads/image-proxy-refresh-seems-inefficient.198729/ this does cause successfully refetched images to not be...

xenforo.com

 

[PASS]

Yes, it is caused by this change.

Fixed - Pruning proxied images does not reset file hash

When proxied images are being pruned after exipiry by calling \XF\Entity\ImageCache::prune(), their file_hash does not get reset. Due to the change in https://xenforo.com/community/threads/image-proxy-refresh-seems-inefficient.198729/ this does cause successfully refetched images to not be...

xenforo.com

Hopefully this can be patched soon.

 

[Kirby]

It is already marked fixed for the next release