Duplicate ICODE tags add extra disruptive new lines before, inside and after tag since v2.2.12

T

tlamprecht

Member
Affected version
v2.2.12
Hi,

ran into this a few times since a while already, but only got finally annoyed enough for opening a report today.

Since v2.2.12 selecting a few words, then pressing the Inline code button adds disruptive new lines we need to manually remove again, e.g.: let's show with a screenshot, first after selecting the desired text that should get surrounded by icode tags:

1675859136703.webp

But this is the outcome after pressing the icode button:

1675859156557.webp
As you can see, the editing/writing flow is completely messed up and a lot of vertical space is wasted.

Earlier XF versions got this right and did not add any newline.

A bit more context:
We moved the icode button to be always visible in the medium and large editor toolbar, as for our forums themes it's required rather often.

And while at it, why the need for two separate buttons/tags? As e.g., the matrix element input field only has one, and it automatically switches between the single (in)line and the multiline code tags (it's markdown based so its `inline` and ```\nmultiline\n``` there) depending on if the selected text contains a newline.
 
Nicolas FR said:
Duplicate... https://xenforo.com/community/threads/inline-code-not-working-correctly.210911/
Click to expand...
ah thx, I searched for "icode" in this forum but did not find that thread.

But I don't see that part adressed there:
tlamprecht said:
And while at it, why the need for two separate buttons/tags? As e.g., the matrix element input field only has one, and it automatically switches between the single (in)line and the multiline code tags (it's markdown based so its `inline` and ```\nmultiline\n``` there) depending on if the selected text contains a newline.
Click to expand...
 
Top Bottom