Confirmed getModeratorsWhoCanActionItem has a bad type hint type, and is missing a null check

[Xon]

Affected version

2.3.12

/**
 * @param $type
 * @param bool $throw
 *
 * @return \XF\ApprovalQueue\AbstractHandler|null
 */
public function getApprovalQueueHandler($type, $throw = false)
...
public function getModeratorsWhoCanActionItem(
    Entity $content,
    bool $notifiableOnly = false
)
...
public function getModeratorsWhoCanActionItem(
    Entity $content,
    bool $notifiableOnly = false
)
{
    $moderatorRepo = $this->repository(ModeratorRepository::class);

    $moderators = $moderatorRepo
        ->findModeratorsForList()
        ->with('User.PermissionCombination')
        ->fetch();

    if ($moderators->count())
    {
        /** @var \XF\ApprovalQueue\AbstractHandler $handler */
        $handler = $this->getApprovalQueueHandler($content->getEntityContentType());

The explicit type hint on type hint on $handler is overriding that getApprovalQueueHandler() can return null.

This should be done at the start of the function and return if there is no handler instead of causing an internal server error;

Error: Call to a member function canView() on null in src/XF/Repository/ApprovalQueueRepository.php at line 239

 

[Xon]

The getModeratorsWhoCanActionItem finder really should push the notify_approval check into the finder query rather than as part of the php processing side

As there is no point doing the view check if no one has actually requested to be notified

 

[Xon]

This was challenging to debug as another XF error made this not get logged;

X

Fixed Thread 'XF::dispatchLoop swallows Throwables from triggerRunOnce()'

Sep 2, 2026

If triggerRunOnce() throws a Error (aka a Throwable not an Exception) then XF::dispatchLoop will swallow it.

public static function triggerRunOnce($rethrow = false)
{
...
try
{
    $fn();
}
catch (\Exception $e)
{
    self::logException($e, true);
    // can't know if we have an open transaction from before so have to roll it back

    if ($rethrow)
    {
        throw $e;
    }
}
...
public function dispatchLoop(RouteMatch $match)
{
...
try
{
    \XF::triggerRunOnce(true);
}
catch (\Throwable $e)
{
...
}

• Xon
• Replies: 2
• Forum: Resolved bug reports