getExtensionCacheFileValue() does not call \XF::getClassForAlias()

[Kirby]

Affected version

2.3.7

When creating extension_hint.php for an Add-on, method \XF\DevelopmentOutput\ClassExtension::getExtensionCacheFileValue() does not call \XF::getClassForAlias() which might create base class names that do not exist unaliased in XenForo 2.3.

Chould this be changed to 'from_class' => '\\' . ltrim(\XF::getClassForAlias($extension->from_class), '\\'), so the unaliased class names are used?

 

[Jeremy P]

The class aliasing system is only a stopgap measure to help retain backwards compatibility, it'll be around a bit longer but it's not something we intend to keep around forever. Any class extensions should be updated to reference the renamed classes, so in some sense having the hints file flag this can be useful.

I'll keep this open though since we should log deprecation notices at least and then we can reconsider.