Fixed Fixed batch size in TemplateRebuild & PhraseRebuild jobs

[Xon]

Affected version

2.1.7

Instead of using calculateOptimalBatch, both TemplateRebuild and PhraseRebuild use fixed counts.

Worse, as the elapsed time check is after the fetch, but before any recompiling is done making it possible for no progress to be made if timing works out poorly.

 

[Xon]

12.5 minutes to install on one SSD based machine compared to 46 seconds on a lesser-spec'd SSD machine indicates that it's not just the SSD at play here, but no doubt the server config as well.

The lack of 'right sizing' of the phrase & template rebuilds jobs probably doesn't help, as it is probably resulting in overfetching for each job run

 

[Sim]

Has this changed in v2.1.7 ?

I should do a v2.1.6 install on my dev server to see how it compares to the 12.5 minute install!

 

[Sim]

LOL ... no, v2.1.6 was even worse

I might try v2.0.x for comparison.

 

[Sim]

v2.0.12 took almost as long - still over 12 minutes.

I suspect it's my VPS that's at fault here. Might be time to migrate my dev installs to a new server.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.8).

Change log:

Use optimal batch sizing when rebuilding templates and phrases.

There may be a delay before changes are rolled out to the XenForo Community.