Partial fix findModeratorsForList can cause N+1 queries for moderator permission checks

[Xon]

Affected version

2.0.4

When viewing reports, findModeratorsForList's with clause includes the 'User' but not 'User.PermissionCombination'. As such if canViewContent touches a visitor's global permission set, this can triggers an additional query per moderator who exists.

A simple problem exists if canViewContent touches node permissions as well.

 

[Mike]

I have done some unnecessary query reduction where it was direct to do so. You have a separate bug report with some overlap so I'll comment more there: https://xenforo.com/community/threads/multiple-n-1-query-behaviour-when-viewing-reports.156494/