Awaiting feedback Fatal Error on trying to upgrade to Xenforo 2.3.11

[Grumpy Squid]

Affected version

2.3.10 -> 2.3.11

Went to try and upgrade to Xenforo 2.3.11 from the previous version and when running the install we got hit with this fatal error:

Fatal error: Declaration of XF\ThreadType\Article::setupMessagePreparer(XF\Entity\Thread $thread, XF\Entity\Post $post, XF\Service\Message\Preparer $preparer) must be compatible with XF\ThreadType\AbstractHandler::setupMessagePreparer(XF\Entity\Thread $thread, XF\Entity\Post $post, XF\Service\Message\PreparerService $preparer) in /srv/www/SITE.URL.HERE/public/src/XF/ThreadType/Article.php on line 44

Any ideas on how to resolve this so we can upgrade would be greatly appreciated.

 

[Chris D]

Firstly, I'd probably download the 2.3.10 package and restore your installation by uploading the files from there.

Next, you probably want to make sure there are no stale files from older installations. You can do this with:

php cmd.php xf:file-clean-up --dry-run

Let us know what that lists if anything.

 

[Grumpy Squid]

Console says Not enough arguments (missing: "addon") when running that command

 

[AndyB]

Console says Not enough arguments (missing: "addon") when running that command

The correct command is:

php cmd.php xf:file-clean-up XF --dry-run

Make sure you first change to the directory that XF is installed in.

 

[Grumpy Squid]

Thank you, also yikes, we have 663 files to be deleted. I'll schedule some maintenance time and run the not dry version of the command and see if it resolves the issue, but I imagine it will. Thanks to both of you.

 

[Grumpy Squid]

I ran the command on our staging server which is an exact copy of our main site. After cleaning up all files and rerunning the upgrade process it succeeded with no issues.

I consider this problem resolved, as the real upgrade later this week should go exactly the same way.

For those that find this thread in the future, I hope cleaning up your excess junk files also resolves your upgrade issues.

Thanks again everyone.

 

[Cyberkef]

Had same issue today, with our setup (private git -> build container -> deploy on host) I deleted the whole src/XF folder and replaced it with the files from the zip (= 630 files deleted, seeing the higher number of @Grumpy Squid I probably still missed some), retriggered upgrade manually in container via php cli.php after redeploy and was solved