Not a bug Entity verify* does not pass reference variable

[truonglv]

Affected version

2.0.7

As the title when method is: verifyColumnName it's not pass reference value.

 

[Chris D]

I don't think it matters as long as the method call handles the variable as a reference. As a code example:

<?php

class A
{
   public function verifyThing(&$value)
   {
      $value = 'abc';
   }
}

$a = new A();
$value = '123';
$a->verifyThing($value);
\XF::dump($value); // value is 'abc'

It's more strict when using call_user_func_array because the validation of what parameters are expected is stricter.

 

[truonglv]

I don't think it matters as long as the method call handles the variable as a reference. As a code example:

<?php

class A
{
   public function verifyThing(&$value)
   {
      $value = 'abc';
   }
}

$a = new A();
$value = '123';
$a->verifyThing($value);
\XF::dump($value); // value is 'abc'

It's more strict when using call_user_func_array because the validation of what parameters are expected is stricter.

Whoooops. I can pass reference by myself. I need more coffee to work. LOL