mattrogowski
Well-known member
- Affected version
- 2.3.7
You can enter values of "30" and "20" like this:
This then throws an error
Should either validate the option values to enforce they're the right way round, or check which one is larger in the controller. I guess instead of:
could do:
This then throws an error
ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min) src/XF/Pub/Controller/AbstractController.php:529Should either validate the option values to enforce they're the right way round, or check which one is larger in the controller. I guess instead of:
PHP:
mt_rand($options->discourageDelay['min'], $options->discourageDelay['max'])could do:
PHP:
mt_rand(min($options->discourageDelay['min'], $options->discourageDelay['max']), max($options->discourageDelay['min'], $options->discourageDelay['max']))