Lack of interest Direct superglobal access

[Kirby]

There are a few locations where XenForo directly accesses $_POST/$_GET:

• \XF\Spam\AbstractChecker::logSpamTrigger()
• \XF\Payment\PayPal::setupCallback()
• \XF\Payment\TwoCheckout::getLogData()
• \XF\Http\Error::getRequestDataForExceptionLog()
• \XF\Mvc\Controller::assertValidPage()
• \XF\Pub\Controller\Report::actionClosed()

This is problematic in integration scenarios, it would therefore be great if access could be routed through XF\Http\Request instead.

 

[Chris D]

It looks like the places we do this are explicitly because we want either $_GET or $_POST but not both and the Request object doesn't attempt to separate them, as it stands.

It's not really clear what "integration scenarios" means so without additional context this seems to be a suggestion, rather than a bug and with a clearer case set out it may be something we can consider in the future.