When upgrading from 2.2 to 2.3.8 (now 2.3.10) a bit over a month ago I tested dark mode on my test system, ran into issues and decided not to bother with it for the moment and look into it later. Later is now and I do not get the problem.
In principle it works as it should apart from two killer issues:
1.) when I enable variations to enable dark mode...
... my header graphic is not displayed any more, neither in bright nor in dark mode. Instead there is a broken image. When I check the URL for the logo it looks like this:
if I switch off variations the URL looks like that...
and works like a charm (as it has always done). The logo is there and should work - but for some unknown reason the URL does not get rendered correctly when turning on variations.
2. Also, I do miss the button to switch between modes near the language selector.
I do run a custom style that I set up as child of the XF default style. The only difference is that I changed some colors, mainly the background color and obviously the logo. When I use the default style instead everything works flawlessly: The option to switch is there as is the XF logo in the header. But it does get even more weird: On my test system it did not work before but does work now for unknown reasons: The Logo is there, the switch is there and switching between light and dark works flawlessly. I am not aware that I would have changed anything to make this happen.
Assuming the fact that I run a child theme might be the issue, to test further, I did create a new style that is not a child of the default style by exporting both, the default style and my child style and importing them into a new one on the highest hierarchy level, first the default style and then overwriting it with my style - and ended up with the same issues.
Any idea what might cause the issues?
In principle it works as it should apart from two killer issues:
1.) when I enable variations to enable dark mode...
... my header graphic is not displayed any more, neither in bright nor in dark mode. Instead there is a broken image. When I check the URL for the logo it looks like this:
Code:
https://myforumurl/var(--xf-publicLogoUrl)if I switch off variations the URL looks like that...
Code:
https://myforumurl/data/assets/logo/logo-small_192.pngand works like a charm (as it has always done). The logo is there and should work - but for some unknown reason the URL does not get rendered correctly when turning on variations.
2. Also, I do miss the button to switch between modes near the language selector.
I do run a custom style that I set up as child of the XF default style. The only difference is that I changed some colors, mainly the background color and obviously the logo. When I use the default style instead everything works flawlessly: The option to switch is there as is the XF logo in the header. But it does get even more weird: On my test system it did not work before but does work now for unknown reasons: The Logo is there, the switch is there and switching between light and dark works flawlessly. I am not aware that I would have changed anything to make this happen.
Assuming the fact that I run a child theme might be the issue, to test further, I did create a new style that is not a child of the default style by exporting both, the default style and my child style and importing them into a new one on the highest hierarchy level, first the default style and then overwriting it with my style - and ended up with the same issues.
Any idea what might cause the issues?
