[cv6] Node Icons & Tools 1.5.1 Release Candidate 3

[Hoffi]

Go to this add-on's template : nodeicon.less​

Change the opacity there.

Yep. Its there. I will think over to add some additional Style Settings to make this easier.

 

[zoldos]

Speaking of that, is there a way to make the opacity more noticeable? I use custom uploaded node images and even with opacity at the lowest/highest setting respectively, you can barely tell the difference with read/unread nodes.

 

[Hoffi]

Speaking of that, is there a way to make the opacity more noticeable? I use custom uploaded node images and even with opacity at the lowest/highest setting respectively, you can barely tell the difference with read/unread nodes.

There are different options. If you have colorful Icons, you can use filter greyscale or sepia.

But in most environments opacity 0.5 is 50% transparent, that should be markable.

filter: grayscale(100%);

 

[zoldos]

I fixed it. I was editing the wrong code in the nodeicon css file. Thanks for an awesome mod!

 

[Hoffi]

I fixed it. I was editing the wrong code in the nodeicon css file. Thanks for an awesome mod!

Okay, which indicates, that I will build a new version with some additional options for the Icon. Thanks for the input.

 

[zoldos]

You're welcome! Looking forward to it!

 

[zoldos]

Okay, which indicates, that I will build a new version with some additional options for the Icon. Thanks for the input.

I found another issue you may want to address. I tried to upload a custom node icon image with the same filename as one that was already uploaded and it threw a whole page of server errors. lol Might want to check it out! (when I changed the filename of the upload it worked perfectly)

 

[Hoffi]

I found another issue you may want to address. I tried to upload a custom node icon image with the same filename as one that was already uploaded and it threw a whole page of server errors. lol Might want to check it out! (when I changed the filename of the upload it worked perfectly)

I am using the asset upload function from XF. I am not sure if I can change there anything.

 

[benFF]

Okay, which indicates, that I will build a new version with some additional options for the Icon. Thanks for the input.

Be cool if you could set different sizes for desktop/mobile without needing to edit css then

 

[Hoffi]

Be cool if you could set different sizes for desktop/mobile without needing to edit css then

Initially I wanted to not upload more than image per node. It was initially designed for the use of FA Icons and SVG.
Will think over it.

 

[benFF]

Initially I wanted to not upload more than image per node. It was initially designed for the use of FA Icons and SVG.
Will think over it.

Sorry I mean the setting in the options now to set the max size. No need different images

 

[Hoffi]

Sorry I mean the setting in the options now to set the max size. No need different images

Ah, okay. Point taken, thanks.

I think I will introduce some Style Settings.

 

[zoldos]

I am using the asset upload function from XF. I am not sure if I can change there anything.

Should I report this as a XF bug then?

 

[Hoffi]

Should I report this as a XF bug then?

Let me check it before, how it behaves in different situations.

 

[Hoffi]

I found another issue you may want to address. I tried to upload a custom node icon image with the same filename as one that was already uploaded and it threw a whole page of server errors. lol Might want to check it out! (when I changed the filename of the upload it worked perfectly)

I can't reproduce this behaviour.

Can you check if this happens also in other Asset-Upload locations like in styles?

 

[zoldos]

I can't reproduce this behaviour.

Can you check if this happens also in other Asset-Upload locations like in styles?

It doesn't seem to happen in the style asset uploads. I've attached the server error for reference and tech support said to contact you:

ErrorException: [E_WARNING] fopen(/var/www/vhosts/zoldos.net/httpdocs/data/assets/nodeicons/icons8-chat-100.png): failed to open stream: Permission denied src/vendor/league/flysystem/src/Adapter/Local.php:157
Generated by: zoldos Feb 28, 2022 at 8:41 PM
Stack trace

0 [internal function]: XF::handlePhpError(2, '[E_WARNING] fop...', '/var/www/vhosts...', 157, Array)
1 src/vendor/league/flysystem/src/Adapter/Local.php(157): fopen('/var/www/vhosts...', 'w+b')
2 src/vendor/league/flysystem/src/Adapter/Local.php(190): League\Flysystem\Adapter\Local->writeStream('assets/nodeicon...', Resource id #110, Object(League\Flysystem\Config))
3 src/vendor/league/flysystem/src/Filesystem.php(119): League\Flysystem\Adapter\Local->updateStream('assets/nodeicon...', Resource id #110, Object(League\Flysystem\Config))
4 [internal function]: League\Flysystem\Filesystem->putStream('assets/nodeicon...', Resource id #110, Object(League\Flysystem\Config))
5 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(431): call_user_func_array('parent::putStre...', Array)
6 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(395): League\Flysystem\EventableFilesystem\EventableFilesystem->callFilesystemMethod('putStream', Array)
7 src/vendor/league/flysystem-eventable-filesystem/src/EventableFilesystem.php(71): League\Flysystem\EventableFilesystem\EventableFilesystem->delegateMethodCall('putStream', Array)
8 src/vendor/league/flysystem/src/MountManager.php(615): League\Flysystem\EventableFilesystem\EventableFilesystem->putStream('assets/nodeicon...', Resource id #110, Array)
9 src/XF/Util/File.php(187): League\Flysystem\MountManager->putStream('assets/nodeicon...', Resource id #110, Array)
10 src/XF/Service/Asset/Upload.php(112): XF\Util\File::copyFileToAbstractedPath('/tmp/phpB8hzax', 'data://assets/n...')
11 src/XF/Admin/Controller/Asset.php(44): XF\Service\Asset\Upload->copyImage()
12 src/XF/Mvc/Dispatcher.php(352): XF\Admin\Controller\Asset->actionUpload(Object(XF\Mvc\ParameterBag))
13 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF:Asset', 'Upload', Object(XF\Mvc\RouteMatch), Object(cv6\NodeIcon\XF\Admin\Controller\Asset), NULL)
14 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(cv6\NodeIcon\XF\Admin\Controller\Asset), NULL)
15 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
16 src/XF/App.php(2351): XF\Mvc\Dispatcher->run()
17 src/XF.php(517): XF\App->run()
18 admin.php(13): XF::runApp('XF\Admin\App')
19 {main}
Request state
array(4) {
["url"] => string(24) "/admin.php?assets/upload"
["referrer"] => string(63) "https://zoldos.net/admin.php?forums/member-introductions.3/edit"
["_GET"] => array(1) {
["assets/upload"] => string(0) ""
}
["_POST"] => array(5) {
["type"] => string(9) "nodeicons"
["_xfRequestUri"] => string(45) "/admin.php?forums/member-introductions.3/edit"
["_xfWithData"] => string(1) "1"
["_xfToken"] => string(8) "****"
["_xfResponseType"] => string(4) "json"
}
}

 

[Hoffi]

I will take a look, but I am not sure.

If you use the same Icon more often, just copy and paste the same path to all forums. Actually you have one Icon uploaded several times, what is also bad for loading time and traffic.

 

[zoldos]

I will take a look, but I am not sure.

If you use the same Icon more often, just copy and paste the same path to all forums. Actually you have one Icon uploaded several times, what is also bad for loading time and traffic.

I messed around with it and got the error one additional time, then everything worked. Weird! I made it one single file for all icons.

Thanks!

 

[Hoffi]

Good to hear that it works now!

 

[Empty]

Hello I've uploaded several svg files to this (they're mostly font awesome 6 icons that aren't recognized by this addon) and noticed this frustrated issue where the icons load in as black first before switching to the proper color. What can I do to prevent this?