Not a bug Conditional with empty PreEscaped always return true

[truonglv]

Affected version

Latest

PreEscaped {#4729 
  +value: ""
  +escapeType: "html"
}

I don't know this is as designed or be an bug? But if this is as designed, very weird.

 

[Chris D]

It’s an object so if the object exists then it will evaluate to true - just like it would in PHP.

There's a special templater function called empty that can be used to evaluate such things:

<xf:set var="$preEscaped"></xf:set>
{{ dump($preEscaped) }}
<xf:if is="empty($preEscaped)">
   Empty
<xf:else />
   Not empty
</xf:if>

This will output "Empty".

<xf:set var="$preEscaped">Test</xf:set>
{{ dump($preEscaped) }}
<xf:if is="empty($preEscaped)">
   Empty
<xf:else />
   Not empty
</xf:if>

This will output "Not empty".

It's worth noting that if you can "trust" or you handle the escaping of the original value yourself, then you can just do this:

<xf:set var="$var" value="" />
{{ dump(var) }}
<xf:if is="!$var">
   Empty
<xf:else />
   Not empty
</xf:if>

 

[truonglv]

It’s an object so if the object exists then it will evaluate to true - just like it would in PHP.

There's a special templater function called empty that can be used to evaluate such things:

<xf:set var="$preEscaped"></xf:set>
{{ dump($preEscaped) }}
<xf:if is="empty($preEscaped)">
   Empty
<xf:else />
   Not empty
</xf:if>

This will output "Empty".

<xf:set var="$preEscaped">Test</xf:set>
{{ dump($preEscaped) }}
<xf:if is="empty($preEscaped)">
   Empty
<xf:else />
   Not empty
</xf:if>

This will output "Not empty".

It's worth noting that if you can "trust" or you handle the escaping of the original value yourself, then you can just do this:

<xf:set var="$var" value="" />
{{ dump(var) }}
<xf:if is="!$var">
   Empty
<xf:else />
   Not empty
</xf:if>

Thank you. It's still weird with previous XF version . Cause i have used callback for some places.

 

[truonglv]

Hi @Chris D In the XF 2.0.5 I have this issue again. Same above object but i receive two results.

{{ dump(empty($var)) }} // output ""
{{ dump(!empty($var)) }} // output true
{{ dump($var is not empty) }} // output false

It's strange.