Digital Doctor
Well-known member
See the white space to the right and left of the dropdown ?
I think that is new.
Is it ?
I figure that space will have google ads in it soon.
Has it always been there ?
It was a misrepresentation as the background was white.Your screenshot in the first post shows exactly the same behaviour as I stated.
This change the native omnibox to look and behave a bit more like the HTML Instant Extended one.
The popup positioning logic now has to be done at a bit of a higher level since it needs to know the window width as well as just the omnibox width. I added a new function in LocationBar:elegate to get this that's implemented by the toolbar view (the lowest-level UI component that knows about the window width as well as the omnibox width).
More information must now be passed to the popup, so I added a new OmniboxViewDelegate that's implemented by the LocationBar to give the popup its context. This cleaned up some dependencies where the popup had to know about the location bar and did things silly things like this:
location_bar_->GetWidget()->GetNativeView()
We use essential cookies to make this site work, and optional cookies to enhance your experience.