Closed Checking trusted proxy provider is more complicated than it needs to be

[Kirby]

Affected version

2.2.12

\XF\Http\Request has public data to check if the request was received through a trusted provider (Google, Cloudflare) - but it does not remember if it was and method ipMatchesRanges is protected.

So if I need to check wether the request was received through a trusted provider (for example to decide if some request headers can be truested) I have to somewhat duplicate code and re-do checks that already had been done.

Could this be simplified a bit?

• Move the code from \XF\Http\Request::ipMatchesRanges to a public static method in \XF\Util\Ip so it can be reused; keep the protected method for compatibility and just make it call the util method)
• Remember if the request was received from a trusted provider and somehow make that information available to callers, eg. smth. like method isReceivedFromTrustedProvider(string $provider): bool

 

[XF Bug Bot]

Automated triage: Design issue

Thank you for reporting this issue. This is accurate for the current version: the proxy range check is still internal, and whether a request came through Cloudflare or Google is not stored for other code to use. Since the existing code works as written, this is an improvement to how the feature is designed rather than a bug.

This is an automated assessment. A member of staff may review and update it.