Fixed Can't feature specific thread

[Russ]

Affected version

2.3 Beta 3

I have an "Ultimate test thread" on my dev site and for whatever reason I can't seem to feature it. Nothing crazy in the thread. Images inserted, images attached, zips attached, various default BBcode's on the first post. Not sure what's going on.

Error:

Oops! We ran into some problems.
LogicException: Instances of XF\Db\AbstractAdapter cannot be serialized or unserialized in src/XF/Db/AbstractAdapter.php at line 686
XF\Db\AbstractAdapter->__sleep()
serialize() in src/XF/Job/Manager.php at line 551
XF\Job\Manager->_enqueue() in src/XF/Job/Manager.php at line 487
XF\Job\Manager->enqueue() in src/XF/Repository/Webhook.php at line 121
XF\Repository\Webhook->queueWebhook() in src/XF/FeaturedContent/AbstractHandler.php at line 237
XF\FeaturedContent\AbstractHandler->onContentFeature() in src/XF/Service/FeaturedContent/Creator.php at line 125
XF\Service\FeaturedContent\Creator->_save() in src/XF/Service/ValidateAndSavableTrait.php at line 42
XF\Service\FeaturedContent\Creator->save() in src/XF/ControllerPlugin/FeaturedContent.php at line 52
XF\ControllerPlugin\FeaturedContent->actionCreate() in src/XF/ControllerPlugin/FeaturedContent.php at line 35
XF\ControllerPlugin\FeaturedContent->actionFeature() in src/XF/Pub/Controller/Thread.php at line 1021
XF\Pub\Controller\Thread->actionFeature() in src/XF/Mvc/Dispatcher.php at line 352
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 258
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 115
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 57
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2590
XF\App->run() in src/XF.php at line 532
XF::runApp() in index.php at line 20

• No webhooks activated (mentions that)
• No add-ons enabled
• Default style tested
• Tested filling in featured title/snippet/image with no luck as well, same error

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.0 Beta 4).

Change log:

Avoid a seralization error when enqueuing a webhook result containing a phrase object.

There may be a delay before changes are rolled out to the XenForo Community.

 

[Chris D]

Incidentally, there was another bug fix resulting from this. I note you said "No webhooks activated" which led me to wonder why you got this error at all. We were including inactive webhooks in our webhook cache so the code was still running even though there wasn't any webhooks that would be sent.

So thanks X 2!