Fixed Can't easily change options for thumbnail generation

[Kirby]

Affected version

2.2 Beta 1

I'd like to change the options (image quality) for media gallery thumbnails.

However, the methods of \XFMG\Service\Media\ThumbnailGenerator do not pass the quality parameter to $image->save().

So as far as I can see there are only two options to achieve this, but both feel kinda ugly & hacky

1. Override the affected methods of \XFMG\Service\Media\ThumbnailGenerator effectively duplicating a lot of code
2. Override method save() in the image classes and somehow override the settings there if applicable

If the methods of \XFMG\Service\Media\ThumbnailGenerator did take optional parameters $format and $quality and pass them down to [ICODE$image->]save()[/ICODE], changing the options would be much cleaner.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XFMG release (2.2.0 Beta 4).

Change log:

Allow thumbnail options to be customised in the thumbnail generator services.

There may be a delay before changes are rolled out to the XenForo Community.