Fixed Bug in Discourse import plugin

[Commander]

Affected version

1.5.2XFI

If there are users on the Discourse forum who for any reason do not have a set password, i.e. there is no value for the password_hash and salt columns in the Discourse PostgreSQL database for the user ID, i.e. the values are NULL, the Xenforo import plugin will skip those users and will not import them. (You will not get any error or log because of this.)

The reproduction was done in such a way that when a password was manually added to Discourses for a user who did not have one, XFI successfully added that one user on the repeated import.

It is necessary to create a mechanism so that when importing, the verification of whether sha256 is present or not can be skipped on Xenforo importer part.

 

[Jeremy P]

In my testing, setting a null value for the password_hash and salt did not result in users being skipped. I'm curious if maybe the missing values correspond to an additional anomaly in the source data that we don't anticipate. If anyone running into this is comfortable providing a dump of some of their Discourse tables, it would be very helpful to progress a fix here.

 

[masmo]

@Commander
Hi, I'm trying to import another Discourse 3.1.0.beta4 forum and I have the same problem.
Did you understand how to fix it?

@Jeremy P if you want I can send you the dump of the database, just tell me how can i send it to you.

Thanks

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XFI release (1.5.3).

Change log:

Import Discourse users without corresponding avatar record

There may be a delay before changes are rolled out to the XenForo Community.

 

[Jeremy P]

This should be resolved in the next importers release, but if there are further issues feel free to open a new bug report. The issue wasn't so much the missing password hashes, it was that users with missing password hashes did not have corresponding avatar records. Thanks to @masmo for providing a database dump which was instrumental in getting this resolved.

 

[masmo]

I confirm, now it works perfectly.
Thanks for the great and fast support!