Browser Detection 2.3.0

[Earl]

If I don't have page caching enabled, Do I have to enable it in order to add these lines to config.php?

$config['pageCache']['onSetup'] = function (\XF\PageCache $pageCache) {

    $pageCache->setCacheIdGenerator(function(\XF\Http\Request $request) {

        return \SV\BrowserDetection\CacheHelper::getPageCacheId($request);

    });

};

I only have these memecach cache settings in my config.php

$config['cache']['enabled'] = true;
$config['cache']['provider'] = 'Memcached';
$config['cache']['config'] = [
    'server' => '127.0.0.1'
];

$config['cache']['sessions'] = true;

 

[Mr. Jinx]

You will only need those extra lines if you have pagecaching enabled.
Something like:

$config['pageCache']['enabled'] = true;
$config['pageCache']['onSetup'] = function (\XF\PageCache $pageCache) {
    $pageCache->setCacheIdGenerator(function(\XF\Http\Request $request) {
        return \SV\BrowserDetection\CacheHelper::getPageCacheId($request);
    });
};
$config['cache']['context']['page']['provider'] = 'Redis';
$config['cache']['context']['page']['config'] = [
        'host' => '127.0.0.1',
        'port' => 6379
        ];

...but I like your question, because I have recently turned on pagecaching and totally forgot about this extra piece of code!

 

[Xon]

If I don't have page caching enabled, Do I have to enable it in order to add these lines to config.php?

Nope, that is only required if you are using page cache and need to cache output for mobile vs desktop clients

 

[Mr. Jinx]

If I'm using this add-on only because it is a requirement for Elastic Search Essentials add-on and I have pagecache on.
Do I need those extra lines in config.php?

 

[Xon]

If you are using page cache, I'ld recommend it. Elasticsearch Essentials add-on does vary HTML based on if the user is mobile/desktop.

 

[btmgreg]

@Xon Hi there. Could I use this to add a conditional to a widget to only display or not display on mobile devices?

 

[Xon]

@Xon Hi there. Could I use this to add a conditional to a widget to only display or not display on mobile devices?

Something like this should work;

$xf.mobileDetect && $xf.mobileDetect.isMobile()

 

[btmgreg]

Something like this should work;

$xf.mobileDetect && $xf.mobileDetect.isMobile()

I appreciate your help, Xon. I did try that after installing the addon - but it doesn't appear to do anything.



I've tried with, and without both parts just in case I've misunderstood. Example -

$xf.mobileDetect && $xf.mobileDetect.isMobile()
$xf.mobileDetect
$xf.mobileDetect.isMobile()

I appreciate your time.

 

[Xon]

The 'isMobile' check is based on user-agent, how are you testing it?

 

[btmgreg]

The 'isMobile' check is based on user-agent, how are you testing it?

Via dev tools on Google Chrome. I emulated an iPhone XR and a few others. I assumed as you can't edit them, they contain the appropriate user-agent strings.

 

[Xon]

Xon updated Browser Detection with a new update entry:

2.3.0 - Feature update

This add-on is now available on atelieraphelion.com

• Require XenForo 2.2+
• Require php 7.2+
• Update MobileDetect library to 3.74.0 (Patched to support php 7.2, instead of php 7.4+)

Read the rest of this update entry...

 

[benFF]

@Xon

Is there a way to use this via the criteria system? Easily of course, I don't expect you to walk me through it for a free addon

View attachment 245060

This would be great, if it could add a few checkboxes like Siropu does with his Ad system

 

[Ivancas]

@Xon any idea why the following conditional triggers this error?

<xf:if is="$xf.mobileDetect && $xf.mobileDetect.isMobile() || $xf.mobileDetect.is-tablet()">

• ErrorException: Template error: [E_USER_WARNING] Cannot call method is-tablet on a non-object (NULL)
• src/XF/Template/Templater.php:1176

 

[Xon]

@Xon any idea why the following conditional triggers this error?

<xf:if is="$xf.mobileDetect && $xf.mobileDetect.isMobile() || $xf.mobileDetect.is-tablet()">

The isTablet invocation isn't right, and you need brackets around the Or'ed parts.

Something like:

<xf:if is="$xf.mobileDetect && ($xf.mobileDetect.isMobile() || $xf.mobileDetect.isTablet())">

 

[Ivancas]

The isTablet invocation isn't right,

 

[Xon]

View attachment 292407

That is a css class attribute, not the template function name.