Bad quality .png images when I save them using XF's createImageFromFile method.

  • Thread starter Thread starter account8226
  • Start date Start date
A

account8226

Guest
Hello,

When I upload an image, and save it as a .png, the quality is quite bad, it's not anymore transparant and there are kinds of colored stripes/backgrounds.

It's not doing that for avatars, so I guess the problem is in my code.

Any ideas ?
 
Last edited by a moderator:
whynot said:
Did you try it with another browser?
Click to expand...

The problem is nor from the web server, nor from the client, since it's working for xenforos' core image
uploads.

It seems that in my addon, it uploads all the time the image, but in some cases the .png transparent image got a big loss of quality on the transparent background.
 
Here is an example, I would like to upload this image :
mario.webp

And after uploading it using my addon, the result is the following :
0cf6f5401bd5d387c312e700468e3503.webp
 
Have you tried running the convert from the command line to help isolate the problem?
 
TheTigerBlueCrow said:
Hello,

When I upload an image, and save it as a .png, the quality is quite bad, it's not anymore transparant and there are kinds of colored stripes/backgrounds.

Is not doing that for avatars, so I guess the problem is in my code.

Any ideas ?
Click to expand...

AndyB said:
Have you tried running the convert from the command line to help isolate the problem?
Click to expand...
If you want to convo me with the block of code that processes the image I will try what Andy suggested and see if I can find the problem.
 
EQnoble said:
If you want to convo me with the block of code that processes the image I will try what Andy suggested and see if I can find the problem.
Click to expand...

That's kind of you, I can put the code on here :
PHP: 
public function uploadImage($id, $logo) {
        $uploadedImage = $logo;
     
        if (!$logo->isImage()) {
            throw new XenForo_Exception(new XenForo_Phrase('uploaded_file_is_not_valid_image'), true);
        }
     
        $dimensions = array(
                'width' => $uploadedImage->getImageInfoField('width'),
                'height' => $uploadedImage->getImageInfoField('height'),
        );
 
        $imageType = $logo->getImageInfoField('type');
        if (!in_array($imageType, array(IMAGETYPE_GIF, IMAGETYPE_PNG, IMAGETYPE_JPEG))) {
            throw new XenForo_Exception(new XenForo_Phrase('uploaded_file_is_not_valid_image'), true);
        }
 
        $imageInfo = getimagesize($logo->getTempFile());
        if (!$imageInfo) {
            throw new XenForo_Exception('Non-image passed in to applyAvatar');
        }
        $width = $imageInfo[0];
        $height = $imageInfo[1];
        $imageType = $imageInfo[2];
 
        if (!in_array($imageType, array(IMAGETYPE_GIF, IMAGETYPE_JPEG, IMAGETYPE_PNG))) {
            throw new XenForo_Exception('Invalid image type passed in to applyAvatar');
        }
 
        if (!XenForo_Image_Abstract::canResize($width, $height)) {
            throw new XenForo_Exception(new XenForo_Phrase('uploaded_image_is_too_big'), true);
        }
 
        $target = XenForo_Helper_File::getExternalDataPath().'/profil/'.$id.'.jpg';

        $image = XenForo_Image_Abstract::createFromFile($logo->getTempFile(), $logo->getImageInfoField('type'));
        $image->output(IMAGETYPE_JPEG, $target);    //save
 
        return true;
    }

Some code can be redondant, but I really don't find the mistake. That is in my model, and I'm passing out an ID and the upload image that I catched in my controller with :
PHP: 
$logo = XenForo_Upload::getUploadedFile('logo');

That's realy strange, it's working in some images, and not on others. The upload never fail, but on some images there is that "bug".

The bug happens always on the same images. When I upload these images as a default avatar from XenForo's core, there isn't nay problem.

Thanks for the help.
 
So the image is being converted from png to jpg.

You can test this from the command line like this:

convert test.png test.jpg

If you get the same results, it's an issue with imagemagick and or the png file.
 
AndyB said:
So the image is being converted from png to jpg.

You can test this from the command line like this:

convert test.png test.jpg

If you get the same results, it's an issue with imagemagick and or the png file.
Click to expand...

Nice find dude! When I convert from png to jpg with the command "convert" I have the exact same buggy result.

What is strange, is that when I posted this thread, I was saving from png to png.
 
AndyB said:
Happy to help.

You might like to see if you have the latest version of imagemagick and if not try upgrading it to solve the problem.
Click to expand...

Ok I'll try, but why the same image is working when I upload it as an avatar on my XenForo account ?
 
AndyB said:
Are you asking why does the same image work here on xenforo.com ??
Click to expand...

No, on my server, if I upload the same image as an avatar, it's working. Maybe the avatar upload is not using imagemagick.
 
AndyB said:
Check if you have GD or Imagemagick selected here:

Admin CP -> Home -> Options -> Attachments -> Default Image Processor
Click to expand...

Sorry for the late reply,

I have the first "PHP" option checked, it's not GD (I can't even tick the GD setting).
 
TheTigerBlueCrow said:
Sorry for the late reply,

I have the first "PHP" option checked, it's not GD (I can't even tick the GD setting).
Click to expand...

Sorry it's unclear what you are using by your reply. Here's a screen print of mine. Perhaps you could provide a similar screen print.

pic001.webp
 
Sorry for my English too ;)

Here is what I have, I can't tick the ImageMagick option :
2e7d03208736e49fda7a0b8e2e98a4c2.webp
 
TheTigerBlueCrow said:
Here is what I have, I can't tick the ImageMagick option :
Click to expand...

Okay so the reason when you uploaded that png file and it didn't mess it up is that Xenforo is using GD to convert it to a jpg file.

I suggest you ask your web hosting company to install ImageMagick with the PECL Extension. ImageMagick produces much cleaner converted images. Also there's a hack to turn off the compression so avatars look even better.
 
You must log in or register to reply here.
Back
Top Bottom