any php/html guru here?

[Mike Law]

Hi guys,

I need to fix the following code, to actually work.
On my wiki site I place a link on each page like this

<?php
echo "<a href=\"http://www.myforumurl.com/search/search?keywords=<?php echo url_encode($page_title); ?>\">Discuss this topic in forums</a>\n";
?>

But when I click on the link it sends me here,

www.myforumurl.com/search/search?keywords=<?php%20echo%20url_encode();%20?>

What am I doing wrong?

 

[ragtek]

You're starting the php process(if it's called so ) 2 times

<?php
echo ..... <?php echo

remove the second <?php echo

 

[ragtek]

this should work

echo '<a href="http://www.myforumurl.com/search/search?keywords=' . urlencode($page_title) . '">Discuss this topic in forums</a>';

this will ONLY work, if you have a url_encode function

I think you want to use urlencode

 

[Mike Law]

same result,

search/search?keywords=%20echo%20url_encode();

 

[Mike Law]

Thanks,

that results
Fatal error: Call to undefined function url_encode() in /

 

[Mike Law]

this will ONLY work, if you have a url_encode function

I think you want to use urlencode

Ah that might be part of the problem.... how do I do that?

 

[ragtek]

that's why i wrote

this will ONLY work, if you have a url_encode function

I think you want to use urlencode

 

[ragtek]

it's the same

just replace url_encode with urlencode

 

[Mike Law]

Thanks for the kind help,

result is now

/search/search?keywords=

using

<div style="float:left;"/>
<?php
echo '<a href="http://www.forum.com/search/search?keywords=' . urlencode($page_title) . '">Discuss this topic in forums</a>';
?>
</div>

See here, next to twitter button

http://bit.ly/p4S4YR

 

[ragtek]

have you checked if $page_title is set?

 

[Mike Law]

No didnt think about that one, sorry!

Title is set as

<title>Direct effect - Law Wiki | Law student Wiki</title>

 

[borbole]

Thanks for the kind help,

result is now

/search/search?keywords=

using

<div style="float:left;"/>
<?php
echo '<a href="http://www.forum.com/search/search?keywords=' . urlencode($page_title) . '">Discuss this topic in forums</a>';
?>
</div>

See here, next to twitter button

http://bit.ly/p4S4YR

You shouldn''t close the first div tag. Also it would be better to include the div inside the php tags.

 

[Mike Law]

Sorted!

Thanks so much for the help!

 

[Dark Matter]

<?php

echo '<div style="float:left"><a href="http://www.forum.com/search/search?keywords=' . urlencode($page_title) . '">Discuss this topic in forums</a></div>';

?>

Would that not have been better above, also there's no need to include a "semi-colon" in that style class seeing as your only using one style attribute only (float).

I would also consider doing away with using an in-line style class, instead putting your css in the extra css box and called it that way using a class rather than adding "style". Helps keep your pages loading faster.

<div class="customsearch">

CSS Added

.customsearch {
float:left;
}

 

[Mike Law]

Thanks, looks much cleaner!