AMPXF - AMP for Xenforo 2 [Deleted]

[Blackbeard]

mazzly updated AMPXF - AMP for Xenforo 2 with a new update entry:

1.3.3 PL1



Read the rest of this update entry...

Love the quick turn around and updates. Wish it was easier to upgrade all my sites not even done with the latest.

 

[Chromaniac]

I wonder siropu keyword addon would have issues with this latest update

 

[Ozzy47]

I wonder siropu keyword addon would have issues with this latest update

One way to find out.

 

[mazzly]

I wonder siropu keyword addon would have issues with this latest update

One site had something with target being set on article for "samCodeUnit", but that might not be due to the addon, but due to owner having set some values.

Also: Page criteria for "don't show on AMP" is good to use

 

[Ozzy47]

Got errors logged:

XF\CssRenderException: Error rendering template public:ampcore.less: .m-formElementExplain is undefined in public:ampcore.less (on or near line 5159) src/XF/CssRenderException.php:87

5156 |
5157 | .inputChoices-explain
5158 | {
5159| .m-formElementExplain();
5160 |
5161 | &.inputChoices-explain--after
5162 | {
------------

#0 src/XF/CssRenderer.php(408): XF\CssRenderException::createFromLessException()
#1 src/XF/CssRenderer.php(342): XF\CssRenderer->renderToCss()
#2 src/XF/CssRenderer.php(250): XF\CssRenderer->renderTemplate()
#3 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates()
#4 src/addons/MaZ/AMP/Styles.php(145): XF\CssRenderer->render()
#5 src/addons/MaZ/AMP/Styles.php(187): MaZ\AMP\Styles::generate()
#6 src/addons/MaZ/AMP/Listener.php(93): MaZ\AMP\Styles::insertCss()
#7 [internal function]: MaZ\AMP\Listener::app_complete()
#8 src/XF/Extension.php(67): call_user_func_array()
#9 src/XF/App.php(2661): XF\Extension->fire()
#10 src/XF/App.php(1970): XF\App->fire()
#11 src/XF/Pub/App.php(440): XF\App->complete()
#12 src/XF/App.php(2194): XF\Pub\App->complete()
#13 src/XF.php(391): XF\App->run()
#14 index.php(20): XF::runApp()
#15 {main}

-------------

Previous Less_Exception_Compiler: .m-formElementExplain is undefined in anonymous-file-0.less - src/vendor/oyejorge/less.php/lib/Less/Tree/Mixin/Call.php:149
#0 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(147): Less_Tree_Mixin_Call->compile()
#1 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(88): Less_Tree_Ruleset->EvalMixinCalls()
#2 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(94): Less_Tree_Ruleset->compile()
#3 src/vendor/oyejorge/less.php/lib/Less/Parser.php(199): Less_Tree_Ruleset->compile()
#4 src/XF/CssRenderer.php(404): Less_Parser->getCss()
#5 src/XF/CssRenderer.php(342): XF\CssRenderer->renderToCss()
#6 src/XF/CssRenderer.php(250): XF\CssRenderer->renderTemplate()
#7 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates()
#8 src/addons/MaZ/AMP/Styles.php(145): XF\CssRenderer->render()
#9 src/addons/MaZ/AMP/Styles.php(187): MaZ\AMP\Styles::generate()
#10 src/addons/MaZ/AMP/Listener.php(93): MaZ\AMP\Styles::insertCss()
#11 [internal function]: MaZ\AMP\Listener::app_complete()
#12 src/XF/Extension.php(67): call_user_func_array()
#13 src/XF/App.php(2661): XF\Extension->fire()
#14 src/XF/App.php(1970): XF\App->fire()
#15 src/XF/Pub/App.php(440): XF\App->complete()
#16 src/XF/App.php(2194): XF\Pub\App->complete()
#17 src/XF.php(391): XF\App->run()
#18 index.php(20): XF::runApp()
#19 {main}

array(4) {
["url"] => string(45) "/threads/spider-man-far-from-home.3335/?amp=1"
["referrer"] => bool(false)
["_GET"] => array(1) {
["amp"] => string(1) "1"
}
["_POST"] => array(0) {
}
}

 

[mazzly]

Got errors logged:

XF\CssRenderException: Error rendering template public:ampcore.less: .m-formElementExplain is undefined in public:ampcore.less (on or near line 5159) src/XF/CssRenderException.php:87

5156 |
5157 | .inputChoices-explain
5158 | {
5159| .m-formElementExplain();
5160 |
5161 | &.inputChoices-explain--after
5162 | {
------------

#0 src/XF/CssRenderer.php(408): XF\CssRenderException::createFromLessException()
#1 src/XF/CssRenderer.php(342): XF\CssRenderer->renderToCss()
#2 src/XF/CssRenderer.php(250): XF\CssRenderer->renderTemplate()
#3 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates()
#4 src/addons/MaZ/AMP/Styles.php(145): XF\CssRenderer->render()
#5 src/addons/MaZ/AMP/Styles.php(187): MaZ\AMP\Styles::generate()
#6 src/addons/MaZ/AMP/Listener.php(93): MaZ\AMP\Styles::insertCss()
#7 [internal function]: MaZ\AMP\Listener::app_complete()
#8 src/XF/Extension.php(67): call_user_func_array()
#9 src/XF/App.php(2661): XF\Extension->fire()
#10 src/XF/App.php(1970): XF\App->fire()
#11 src/XF/Pub/App.php(440): XF\App->complete()
#12 src/XF/App.php(2194): XF\Pub\App->complete()
#13 src/XF.php(391): XF\App->run()
#14 index.php(20): XF::runApp()
#15 {main}

-------------

Previous Less_Exception_Compiler: .m-formElementExplain is undefined in anonymous-file-0.less - src/vendor/oyejorge/less.php/lib/Less/Tree/Mixin/Call.php:149
#0 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(147): Less_Tree_Mixin_Call->compile()
#1 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(88): Less_Tree_Ruleset->EvalMixinCalls()
#2 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(94): Less_Tree_Ruleset->compile()
#3 src/vendor/oyejorge/less.php/lib/Less/Parser.php(199): Less_Tree_Ruleset->compile()
#4 src/XF/CssRenderer.php(404): Less_Parser->getCss()
#5 src/XF/CssRenderer.php(342): XF\CssRenderer->renderToCss()
#6 src/XF/CssRenderer.php(250): XF\CssRenderer->renderTemplate()
#7 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates()
#8 src/addons/MaZ/AMP/Styles.php(145): XF\CssRenderer->render()
#9 src/addons/MaZ/AMP/Styles.php(187): MaZ\AMP\Styles::generate()
#10 src/addons/MaZ/AMP/Listener.php(93): MaZ\AMP\Styles::insertCss()
#11 [internal function]: MaZ\AMP\Listener::app_complete()
#12 src/XF/Extension.php(67): call_user_func_array()
#13 src/XF/App.php(2661): XF\Extension->fire()
#14 src/XF/App.php(1970): XF\App->fire()
#15 src/XF/Pub/App.php(440): XF\App->complete()
#16 src/XF/App.php(2194): XF\Pub\App->complete()
#17 src/XF.php(391): XF\App->run()
#18 index.php(20): XF::runApp()
#19 {main}

array(4) {
["url"] => string(45) "/threads/spider-man-far-from-home.3335/?amp=1"
["referrer"] => bool(false)
["_GET"] => array(1) {
["amp"] => string(1) "1"
}
["_POST"] => array(0) {
}
}

Ahh yes the XF2.1 doesn't support the prepend things.. will move & fix it for upcoming patch release

 

[Deleted member 184953]

Mine gives an error too. Figured they’d fix it eventually

How to fix this problem ? Unable to turn on AMP Real page on Cloudflare ?

 

[mazzly]

mazzly updated AMPXF - AMP for Xenforo 2 with a new update entry:

1.3.3 PL2: Fix style problem with X2.1 and compay with Andy/Similarthreads

• New styles added in 1.3.3 failed due to XF2.1 not supporting the _prepend that XF2.2 does
• Andy/SimilarThreads renders doubly on AMP, this one fixes so the "wide" version is hidden

Read the rest of this update entry...

 

[Chromaniac]

I have reported the bug and submitted logs. They have forwarded it to the relevant team. Would update when they confirm the issue has been dixed

 

[mazzly]

@Ozzy47 Fix is up

@Blackbeard Sorry (Latest is irrelevant unless you use Andy/SimlarThreads or XF2.1)

 

[Blackbeard]

@Blackbeard Sorry (Latest is irrelevant unless you use Andy/SimlarThreads or XF2.1)

I just move to a once a week update process, unless it's a security fix from now on Thanks for the updates and help.

 

[Ozzy47]

@Ozzy47 Fix is up

@Blackbeard Sorry (Latest is irrelevant unless you use Andy/SimlarThreads or XF2.1)

Thanks for the quick patch.

 

[Chromaniac]

siropu keyword linking addon seems to work fine with the latest update. i do wish however if the configured keyword links worked on amp pages

 

[Deleted member 184953]

Hello, embed Codepen (from this addon https://xenforo.com/community/resources/s9e-media-sites.5973/) are not displayed on AMP pages.

BTW i'm not sure what i have to expect from AMPXF on mobile page...
In FAQ there is a tips to check if AMP addon works fine, we have to add at the end of URL threads ?amp=1, well without this the page are displayed normally in my smartphone, so AMP is only for bots ? Users can't see AMP pages ?

I installed this addon because I was swept away by the wave, it is the addon that we must have installed to be in the game! despite my reluctance I wanted to play with everyone ... And it is now that I ask myself the questions .......

 

[mazzly]

Hello, embed Codepen (from this addon https://xenforo.com/community/resources/s9e-media-sites.5973/) are not displayed on AMP pages.

Please open a support ticket with affected URL and I will have a look into it when I have time

In FAQ there is a tips to check if AMP addon works fine, we have to add at the end of URL threads ?amp=1, well without this the page are displayed normally in my smartphone, so AMP is only for bots ? Users can't see AMP pages ?

When someone searches for something in Google/Bing on a phone, they will be sent to the ?amp=1 variant of the page. So visitors coming in from the search engine will see the AMP variant. If the visitor decides to continue browsing your forum, they will be directed automatically to the "real site"

Hope that clears some things up

 

[sevenmix]

Hi

After the last update, i have nos this error on addonflare paid ads:

Error: Call to undefined method MaZ\AMP\XF\Template\Templater22::getAfPaidAds() in src/addons/AddonFlare/PaidAds/Entity/Location.php at line 378
AddonFlare\PaidAds\Entity\Location->get() in src/XF/Mvc/Entity/Entity.php at line 110
XF\Mvc\Entity\Entity->__get() in src/addons/AddonFlare/PaidAds/Entity/Location.php at line 112
AddonFlare\PaidAds\Entity\Location->canPurchase() in src/addons/AddonFlare/PaidAds/Repository/Location.php at line 34
AddonFlare\PaidAds\Repository\Location->AddonFlare\PaidAds\Repository\{closure}()
array_filter() in src/XF/Mvc/Entity/AbstractCollection.php at line 189
XF\Mvc\Entity\AbstractCollection->filter() in src/addons/AddonFlare/PaidAds/Repository/Location.php at line 35
AddonFlare\PaidAds\Repository\Location->filterPurchasable() in src/addons/AddonFlare/PaidAds/Pub/Controller/Buy.php at line 32
AddonFlare\PaidAds\Pub\Controller\Buy->actionIndex() in src/XF/Mvc/Dispatcher.php at line 350
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 257
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2300
XF\App->run() in src/XF.php at line 488
XF::runApp() in index.php at line 20

When i disable the amp addon it still works

 

[Deleted member 184953]

Some Font Awesome Icons are not well displayed too, is it normal ?

 

[mazzly]

Some Font Awesome Icons are not well displayed too, is it normal ?

View attachment 245864

First time seeing it like that, please open a support ticket..

 

[mazzly]

Hi

After the last update, i have nos this error on addonflare paid ads:

Error: Call to undefined method MaZ\AMP\XF\Template\Templater22::getAfPaidAds() in src/addons/AddonFlare/PaidAds/Entity/Location.php at line 378
AddonFlare\PaidAds\Entity\Location->get() in src/XF/Mvc/Entity/Entity.php at line 110
XF\Mvc\Entity\Entity->__get() in src/addons/AddonFlare/PaidAds/Entity/Location.php at line 112
AddonFlare\PaidAds\Entity\Location->canPurchase() in src/addons/AddonFlare/PaidAds/Repository/Location.php at line 34
AddonFlare\PaidAds\Repository\Location->AddonFlare\PaidAds\Repository\{closure}()
array_filter() in src/XF/Mvc/Entity/AbstractCollection.php at line 189
XF\Mvc\Entity\AbstractCollection->filter() in src/addons/AddonFlare/PaidAds/Repository/Location.php at line 35
AddonFlare\PaidAds\Repository\Location->filterPurchasable() in src/addons/AddonFlare/PaidAds/Pub/Controller/Buy.php at line 32
AddonFlare\PaidAds\Pub\Controller\Buy->actionIndex() in src/XF/Mvc/Dispatcher.php at line 350
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 257
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2300
XF\App->run() in src/XF.php at line 488
XF::runApp() in index.php at line 20

When i disable the amp addon it still works

Which version? that was a problem in early versions of 1.3.2 but should be fixed now

 

[mazzly]

mazzly updated AMPXF - AMP for Xenforo 2 with a new update entry:

1.3.3 PL3

• Fix page criterias for "show only on AMP" / "don't show on AMP" so they work in Siropus Ad Manager
• Fix icons not showing if the "light" typography is used
• Fix codepen embed to work on AMP pages

Read the rest of this update entry...