Amazon/eBay Parser

Amazon/eBay Parser 2.1.4

No permission to download
I get the errors quite regularly:
1615557962652.webp

They all seem to be related to RSS somehow:

Request state​

array(4) {
["url"] => string(38) "/forums/north-america.97/index.rss"
["referrer"] => bool(false)
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}
 
I’ll have that fixed in the next update. If you want to stop the error for now:

Need to replace line 287 with
PHP:
$newTempUrl .= "&" . str_replace('%', '|||', $element);
in XF/BbCode/Renderer/Html.php.
 
Hmm.. different error now:

Code:
Server error log
ErrorException: [E_NOTICE] Undefined variable: %s%smkevt=1&mkcid=1&mkrid=%s&siteid=0&customid=%s&campid=%s&toolid=%s&mpt=8569361 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php:288
Generated by: Unknown account Mar 12, 2021 at 1:35 PM

Stack trace
#0 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(288): XF::handlePhpError(8, '[E_NOTICE] Unde...', 'sr...', 288, Array)
#1 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(44): Snog\Amazon\XF\BbCode\Renderer\Html->addCampaignToHref('<a href="https:...', Array)
#2 [internal function]: Snog\Amazon\XF\BbCode\Renderer\Html->renderTagUrl(Array, 'https://rover.e...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#3 src/XF/BbCode/Renderer/Html.php(308): call_user_func(Array, Array, 'https://rover.e...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#4 src/XF/BbCode/Traverser.php(61): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#5 src/XF/BbCode/Traverser.php(37): XF\BbCode\Traverser->renderSubTree(Array, Array)
#6 src/XF/BbCode/Traverser.php(20): XF\BbCode\Traverser->renderAst(Array, Object(XF\BbCode\RuleSet), Array)
#7 src/XF/Pub/View/FeedHelper.php(118): XF\BbCode\Traverser->render('Looking to try ...', Object(XF\BbCode\Parser), Object(XF\BbCode\RuleSet), Array)
#8 src/XF/Pub/View/Forum/Rss.php(42): XF\Pub\View\FeedHelper::setupEntryForThread(Object(Laminas\Feed\Writer\Entry), Object(XFMG\XF\Entity\Thread), 'last_post_date')
#9 src/XF/Mvc/Renderer/AbstractRenderer.php(91): XF\Pub\View\Forum\Rss->renderRss()
#10 src/XF/Mvc/Renderer/Xml.php(74): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('XF:Forum\\Rss', '', Array)
#11 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Xml->renderView('XF:Forum\\Rss', '', Array)
#12 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Rss), Object(XF\Mvc\Reply\View))
#13 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Rss), Object(XF\Mvc\Reply\View))
#14 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'rss')
#15 src/XF/App.php(2326): XF\Mvc\Dispatcher->run()
#16 src/XF.php(488): XF\App->run()
#17 index.php(20): XF::runApp('XF\\Pub\\App')
#18 {main}

Request state
array(4) {
  ["url"] => string(38) "/forums/north-america.97/index.rss"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}
 
Is an update needed to cover the new eBay changes that took affect tomorrow described here?:


eBay Partner Network has moved from rover-based tracking links to a new tracking link format, which complies with industry standards and fully supports Tracking Prevention Frameworks such as Apple Webkit ITP, Mozilla Firefox ETP, or Microsoft Edge Tracking Prevention.

All ePN tools and widgets, eBay's Data Feeds and Browse APIs have automatically started serving new tracking links. All remaining rover-based links on your properties will need to be replaced with the new tracking links. Start converting links today with our helpful new Link Conversion Tool, part of the Smart Share browser extension.
 
Is an update needed to cover the new eBay changes that took affect tomorrow described here?:
 
I should have known you took care of it long in advance! Thank you...
 
I tried this again and had to remove it again.

The old links from cgi.ebay.com and manually posted rover.ebay.com links all end up looking like
my.com/item?stuff&here which of course never takes the user to ebay.

New links work, though. (eg, get a product off ebay right now, its good)

But, i have 20 years of old ebay posts and that's where the search traffic and clicks throughs mostly come from.

AMP is also reporting broken links as a result.

example urls:
Code:
http://rover.ebay.com/rover/1/711-53200-19255-0/1?toolid=10029&campid=CAMPAIGNID&customid=CUSTOMID&catId=6000&type=2&ext=350563559471&item=350563559471

https://cgi.ebay.com/ebaymotors/ws/eBayISAPI.dll?ViewItem&item=261238636661
 
I get the errors quite regularly:
View attachment 248385

They all seem to be related to RSS somehow:

Request state​

array(4) {
["url"] => string(38) "/forums/north-america.97/index.rss"
["referrer"] => bool(false)
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}
I'm also getting a lot of these errors.
I'll apply the fix, but that update would be welcome.
Thanks
 
I’ll have that fixed in the next update. If you want to stop the error for now:

Need to replace line 287 with
PHP:
$newTempUrl .= "&" . str_replace('%', '|||', $element);
in XF/BbCode/Renderer/Html.php.
In XF 2.2.5, line 287 is
if ($rule && !empty($rule['stopSmilies']))
replacing that with your line can't be correct.
 
Is this PHP8 incompatible?
I got several of this error.

Code:
ErrorException: Template error: [E_WARNING] Undefined variable $tempurl src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php:287
Generated by: Unknown account Feb 24, 2021 at 10:18 AM
Stack trace
#0 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(287): XF\Template\Templater->handleTemplateError(2, '[E_WARNING] Und...', '/home/nginx/dom...', 287)
#1 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(44): Snog\Amazon\XF\BbCode\Renderer\Html->addCampaignToHref('<a href="http:/...', Array)
#2 [internal function]: Snog\Amazon\XF\BbCode\Renderer\Html->renderTagUrl(Array, 'http://rover.eb...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#3 src/XF/BbCode/Renderer/Html.php(308): call_user_func(Array, Array, 'http://rover.eb...', Array, Array, Object(Snog\Amazon\XF\BbCode\Renderer\Html))
#4 src/XF/BbCode/Traverser.php(61): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#5 src/XF/BbCode/Traverser.php(37): XF\BbCode\Traverser->renderSubTree(Array, Array)
#6 src/XF/BbCode/Traverser.php(20): XF\BbCode\Traverser->renderAst(Array, Object(XF\BbCode\RuleSet), Array)
#7 src/XF/SubContainer/BbCode.php(220): XF\BbCode\Traverser->render('pretty sure I m...', Object(XF\BbCode\Parser), Object(XF\BbCode\RuleSet), Array)
#8 src/XF/Template/Templater.php(2343): XF\SubContainer\BbCode->render('pretty sure I m...', 'html', 'post', Object(XFES\XF\Entity\Post), Array)
#9 [internal function]: XF\Template\Templater->fnBbCode(Object(XF\Template\Templater), false, 'pretty sure I m...', 'post', Object(XFES\XF\Entity\Post))
#10 src/XF/Template/Templater.php(1103): call_user_func_array(Array, Array)
#11 internal_data/code_cache/templates/l1/s8/public/post_macros.php(476): XF\Template\Templater->func('bb_code', Array, false)
#12 src/XF/Template/Templater.php(799): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, NULL)
#13 internal_data/code_cache/templates/l1/s8/public/post_macros.php(66): XF\Template\Templater->callMacro('post_macros', 'post_user_conte...', Array, Array)
#14 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#15 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('user_content', Array, Array, Object(XF\Template\ExtensionSet))
#16 internal_data/code_cache/templates/l1/s8/public/post_macros.php(100): XF\Template\Templater->renderExtension('user_content', Array, Object(XF\Template\ExtensionSet))
#17 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#18 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('content', Array, Array, Object(XF\Template\ExtensionSet))
#19 internal_data/code_cache/templates/l1/s8/public/post_macros.php(135): XF\Template\Templater->renderExtension('content', Array, Object(XF\Template\ExtensionSet))
#20 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#21 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('main_cell_inner', Array, Array, Object(XF\Template\ExtensionSet))
#22 internal_data/code_cache/templates/l1/s8/public/post_macros.php(149): XF\Template\Templater->renderExtension('main_cell_inner', Array, Object(XF\Template\ExtensionSet))
#23 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#24 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('main_cell', Array, Array, Object(XF\Template\ExtensionSet))
#25 internal_data/code_cache/templates/l1/s8/public/post_macros.php(161): XF\Template\Templater->renderExtension('main_cell', Array, Object(XF\Template\ExtensionSet))
#26 src/XF/Template/Templater.php(962): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#27 src/XF/Template/Templater.php(898): XF\Template\Templater->renderExtensionInternal('full_body', Array, Array, Object(XF\Template\ExtensionSet))
#28 internal_data/code_cache/templates/l1/s8/public/post_macros.php(200): XF\Template\Templater->renderExtension('full_body', Array, Object(XF\Template\ExtensionSet))
#29 src/XF/Template/Templater.php(799): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#30 internal_data/code_cache/templates/l1/s8/public/thread_view.php(794): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#31 src/XF/Template/Templater.php(1626): XF\Template\Templater->{closure}(Object(XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#32 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array)
#33 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#34 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#35 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#36 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#37 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#38 src/XF/App.php(2326): XF\Mvc\Dispatcher->run()
#39 src/XF.php(488): XF\App->run()
#40 index.php(20): XF::runApp('XF\\Pub\\App')
#41 {main}

Thank you.
PHP on version 8.0.8 now, any news on this issue?
Thanks a lot.
 
Hi! I'm using Amazon/eBay Parser - a great addon - thanks (y)

However, since the Xenforo HTML Nofitication E-Mails (e.g. Thread Subscriptions) include the content of the post/reply, all the Amazon URLs get rewritten. Which by theory is great, but ... many E-Mail providers rate such E-Mails as phishing attends, if the posted URL and the rewritten URL doesn't match.

Action: failed
Diagnostic-Code: smtp; 554 5.7.0 Reject, id=r-17 - INFECTED: Heuristics.Phishing.Email.SpoofedDomain
Status: 5.7.0
I only get this kinds of complaints when the message contains an Amazon Link rewritten by the add-on.

Could you please consider adding an option for disabling parsing/rewriting of E-Mail content? That would be great and make my life easier.

Thanks!
 
Back
Top Bottom