Fixed Add-on installation: checkRequirements doesn't re-run unless page is refreshed

Arty

Well-known member
Affected version
2.1.0-beta5
There is a small bug on add-on installation page when installing add-on that has checkRequirements() function.

If add-on throws error or warning, XenForo shows that error/warning. However if issue is fixed, clicking "Install" button again will still show old error/warning instead of running checkRequirements() again.

I think this is caused by AJAX implementation. It remembers old cached page, so it doesn't retrieve page again on second click.

It might be confusing to users. For example if add-on requires specific file or directory to be writable, after changing access mode via FTP user is unlikely to refresh admin page, he's likely to click "Install" again and receive old message, which would result in user incorrectly thinking that chmod failed.
 
Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.0.13).

Change log:
Don't cache add-on install and upgrade overlays
Any changes made as a result of this issue being resolved may not be rolled out here until later.
 
Back
Top Bottom