Fixed /account/reactions link bug in v2.1.4? Links missing the anchor portion?

Affected version
2.4.1

iaresee

Member
Ever since the v2.4.1 the /accounts/reactions page has shown broken links for my users.

Here's an example...

If I get a reaction to a post, the alert bell in the top menu looks like this:

Screen Shot 2019-10-14 at 7.27.20 PM.png

And the link is (correctly) this: https://forum.fractalaudio.com/posts/1835802/ -- which takes me directly to my post in the middle of a thread. That link turns into: https://forum.fractalaudio.com/threads/prayers-and-good-vibes-needed.154409/#post-1835802 after you click on it.

If I go to https://forum.fractalaudio.com/account/reactions I see the correct action recorded on this this page:

Screen Shot 2019-10-14 at 7.27.55 PM.png

But that link under the text is: https://forum.fractalaudio.com/threads/prayers-and-good-vibes-needed.154409/

Which takes me to the correct thread, but not the correct position in the thread. The post index, comparing the two links, is wrong never mind the URI syntax is also completely different. It looks like it's missing the anchor portion of the URI when it's displayed in the /account/reactions view. This wasn't the case pre-v2.4.1 as far as I can remember.

Is this is a v2.4.1 bug or is something wrong with my database that needs correcting or rebuilding?

Thanks!
 

Chromaniac

Well-known member
i personally would prefer if xenforo links to the reacted post right on the thread title in recent activity. replies are linked to thread titles. but reactions are not. causing confusion.
 

XF Bug Bot

XenForo bug fixer bot
Staff member
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.1.6).

Change log:
In the news feed, ensure the reaction item is consistent so that "your post" links to the actual post.
There may be a delay before changes are rolled out to the XenForo Community.
 

ehd

Well-known member
Actually after the update to 2.17 the links to the thread
  • are totally gone when someone reacts
  • are still there when someone quoted or answered or mentioned
Thx
 

loslobos1

Member
Go to your admin-cp: forum/admin.php?phrases/search

Search for x_reacted_to_your_post_in_the_thread_y

There put in the link:

Code:
{name} reacted to <a {posterParams}>your post</a> in the thread {title} with {reaction}.

Should have the <a ...> </a>
Fixed. Thank u.
 

iaresee

Member
I just updated to 2.1.7 and this is fixed for me. On the /account/reactions page I now see the "your post" text as a link and the link takes me to the correct position in the thread, not just to the top of the thread.

Screen Shot 2020-01-30 at 11.21.41 PM.png
 
Top