Fixed AbstractWatch::getDefaultWatchNotifyData is defined as protected but overridden as public

Xon

Well-known member
Affected version
2.2.8 Patch 1
XF\Notifier\Post\AbstractWatch::getDefaultWatchNotifyData and XFRM\Notifier\ResourceUpdate\AbstractWatch::getDefaultWatchNotifyData are both defined as;

PHP:
abstract protected function getDefaultWatchNotifyData();

But all the implementations are;
PHP:
public function getDefaultWatchNotifyData()

Brought to you by the "Method visibility shouldn't be overridden" phpstorm inspector when updating two of my add-ons
 
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.9).

Change log:
Update watch notifier getDefaultWatchNotifyData method visibility to match parent class
There may be a delay before changes are rolled out to the XenForo Community.
 
Top Bottom