XF 2.1 _postSave on same row resulting in forceSet error

[asprin]

Hi experts,

In my entity's _postSave function, my use case is to update a column belonging to the same entity. So I'm using the following code:

protected function _postSave()
{
    // sys_id is primary key column on the entity
    $upload = $this->app()->request()->getFile('upload', false, false);
    $filename = 'myfile_'.$this->sys_id.'.'.$upload->getExtension(); // so this becomes something like myfile_123.png
    $this->path_to_file = $filename;
}

This is throwing the forceSet error. So I looked at Xenforo's code and found some samples and tried with the following:

// sys_id is primary key column on the entity
$upload = $this->app()->request()->getFile('upload', false, false);

$filename = 'myfile_'.$this->sys_id.'.'.$upload->getExtension();
$this->set('path_to_file', $filename, ['forceSet' => true]);
$this->save();

This resulted in Duplicate entry 'xxx' for key 'PRIMARY' error message.

So I'm now out of ideas on how to go about achieving this.

(a) I cannot use the _preSave() function because I need the $this->sys_id value which will not be available in presave.
(b) If I use _postSave() function, I've been unsuccessful at getting it to work.

Any suggestions?

 

[Jeremy P]

You could probably do...

$this->fastUpdate('path_to_file', $filename);

Though for derived data you might want to just make this a getter instead of an actual column:

Entities, finders, and repositories | Developer Documentation | XenForo

Developer documentation for XenForo

xenforo.com

 

[Kirby]

$upload = $this->app()->request()->getFile('upload', false, false);

You really do not want to have such code in entities, just like in your recent thread:

XF 2.1 - Is it possible to access form input values in Entity's _preSave() function?

The use case is such that I need to modify the incoming form input value before storing it in the column. For example: function _preSave() { if($this->update()) { $this->starts_in = } }

xenforo.com

 

[Jeremy P]

Ah yeah, overlooked that line. I would strongly caution against coupling file input to entities in this way.

 

[asprin]

Though for derived data you might want to just make this a getter instead of an actual column:

Yep, this seems like a far better approach. Plus it would save me a column on the table as well. But I'll need to have the file uploaded first.

You really do not want to have such code in entities, just like in your recent thread:

But this is something I need to happen after the insert OR when transaction is about to be committed. Reason being is that I need the primary key value of the just inserted record. Are you suggesting I write these lines of code after I call the run() method on the formAction object in my public controller that accepts the form input?

It's just that I understand entity and form inputs should generally not be tightly coupled but was just wondering if there could be exceptions as well.

 

[Lukas W.]

Are you suggesting I write these lines of code after I call the run() method on the formAction object in my public controller that accepts the form input?

The FormAction class exposes a method called complete which you can pass a closure into that will be fired once the form has been successfully executed.

 

[asprin]

You could probably do...

$this->fastUpdate('path_to_file', $filename);

Though for derived data you might want to just make this a getter instead of an actual column:

Entities, finders, and repositories | Developer Documentation | XenForo

Developer documentation for XenForo

xenforo.com

This is a "good to know" stuff. Thanks for that.

The FormAction class exposes a method called complete which you can pass a closure into that will be fired once the form has been successfully executed.

Thanks. I'll test this and see how it goes (assuming I can still access the form data in the closure - mainly the uploaded file in it)

 

[Lukas W.]

You can pass any variable you like into closures: https://www.php.net/manual/en/functions.anonymous.php

 

[asprin]

The FormAction class exposes a method called complete which you can pass a closure into that will be fired once the form has been successfully executed.

It worked. Used the following template:

$form->basicEntitySave($theEntity, $input);

$form->complete(function() use ($theEntity)
{
    $uploads = $this->request->getFile('upload', false, false);          
    if($uploads)
    {
        $uploads->requireImage();
        $filename = 'my_file'.$theEntity->sys_id.'.'.$uploads->getExtension();      
        \XF\Util\File::copyFileToAbstractedPath($uploads->getTempFile(), 'path/to/data/folder/'.$filename);
        $theEntity->path_to_file = $filename;
        $theEntity->save();
    }
}

return $form;

The complete method is giving the last insert Id which I'm able to use in the filename.

Cheers for pointing me in the correct direction.