Recent content by NikitOS

New hardcoded string in 2.3.0 Beta 4: Passkey login in admin:login_form.

@Kirby, we are talking about duotone icons. Used icons can be styled as a whole, but duotone icons consist of two parts, and styles cannot be applied to them.

Progress bars in polls and attachments do not have a border. I don't think it should be here either. Also, the border-radius value should be replaced with @xf-borderRadiusMedium, as done in the polls: it looks much nicer. And in polls and attachments the progress_bar macro should be used.

Since specifying the image URL is optional, it makes sense to check if the URL is provided and not display the broken image:

Currently, EMBED_CONTAINER and OAUTH_CONTAINER call the public:helper_js_global::head macro. In addition, EMBED_CONTAINER also calls public:helper_js_global::body. The included JS is unnecessary and only causes errors. I think it’s better to move the inclusion of CSS out of the...

As said in the title. Template: <div class="block"> <div class="block-container"> <div class="block-body"> <xf:tokeninputrow label="Tags" placeholder="Enter something…" /> </div> </div> </div>

Demo:

The XF\Repository\EmbedResolver::addEmbedsToContent method should use array_merge_recursive instead of array_merge to collect all embeds in posts.

The currency phrase is used in the public:xfrm_resource_edit_macros template, but it is also missing.

Hardcoded strings I found: Attachment optimization in admin:tools_rebuild Avatar optimization in admin:tools_rebuild Profile banner optimization in admin:tools_rebuild Embed code HTML copied to clipboard. in public:featured_content_item_thread, public:post_article_macros and...

Missing phrases: development (in admin:PAGE_CONTAINER) no_prompts_have_been_added_yet (in admin:base_prompt_list) xfi_default_language_character_set (in admin:import_config_macros) leave_direct_message_and_accept_future_responses (in admin:option_template_registrationWelcome and...

The XF.Icon.getVariantClass and XF.Icon.normalizeIconVariant methods do not support "duotone" variant.

In XF 2.2, if a jQuery object is passed as the second argument (onReady) to the XF.setupHtmlInsert method, the innerHTML of the target was replaced with the outerHTML of the elements in the jQuery collection (via Node.appendChild). In XF 2.3, if an HTMLElement object is passed as the second...

@Newsman, you need to bind the function that needs to be called as a callback. For example: XF.on(target, 'click', this.onClick.bind(this));

As said in the title. For example, XF.Icon.getIcon('brands', 'airbnb') returns the following: <i class="fa--xf far fa-airbnb"><svg xmlns="http://www.w3.org/2000/svg" role="img" aria-hidden="true" ><use href="/data/local/icons/regular.svg?v=1711360995#airbnb"></use></svg></i>