Reply to thread

Message: <blockquote data-quote="Kevin" data-source="post: 1546531" data-attributes="member: 21">Yeah, it looks like an update to the YT URL parsing over the years may have broken it.  The function <code class="bbCodeInline">matchCallback</code> in /XF/Bbode/Helper/YouTube.php looks for the 'list' parameter and if found saves it as part of the matched media ID (so a URL like <code class="bbCodeInline">https://www.youtube.com/watch?v=a01QQZyl-_I&list=PLmXxqSJJq-yXrCPGIT2gn8b34JjOrl4Xf&index=10</code> gets turned into <code class="bbCodeInline">a01QQZyl-_I, list: PLmXxqSJJq-yXrCPGIT2gn8b34JjOrl4Xf</code> for the matched ID. That seems to work fine everywhere in XF since the video IDs are recognized & parsed as needed to embed the YT code and is why the actual video still plays in XFMG. With XFMG when retrieving the thumbnail the function <code class="bbCodeInline">getTempThumbnailPath</code> in /src/addons/XFMG/EmbedData/YouTube.php seems to be looking for a video ID with a ":" colon in it and, if found, to parse out just the actual video ID <code class="bbCodeInline">a01QQZyl-_I</code> when creating the thumbnail URL.  So the XF devs know that the media ID could have extra data in it and to work around it to get the real ID. But in the example of <code class="bbCodeInline">a01QQZyl-_I, list: PLmXxqSJJq-yXrCPGIT2gn8b34JjOrl4Xf</code> it doesn't get matched in the regex so the URL requested ends up as <code class="bbCodeInline">https://i.ytimg.com/vi/a01QQZyl-_I, list: PLmXxqSJJq-yXrCPGIT2gn8b34JjOrl4Xf/maxresdefault.jpg</code> instead of <code class="bbCodeInline">https://i.ytimg.com/vi/a01QQZyl-_I/maxresdefault.jpg</code> so it of course fails. My guess is that the regex needs to be updated.  Maybe something like <code class="bbCodeInline">(.*)(\,\.*)</code> to parse on "," instead of the colon but this is where the XF guys know what they're doing far better than I so I'll wait & see what the patch fix looks like.  <img src="https://cdn.jsdelivr.net/joypixels/assets/8.0/png/unicode/64/1f600.png" class="smilie smilie--emoji" loading="lazy" width="64" height="64" alt=":D" title="Big grin    :D"  data-smilie="8"data-shortname=":D" /> </blockquote>

Verification

We value your privacy

We use essential cookies to make this site work, and optional cookies to enhance your experience.

See further information and configure your preferences

Accept all cookies Reject optional cookies
Essential cookies

These cookies are required to enable core functionality such as security, network management, and accessibility. You may not reject these.

Optional cookies

We deliver enhanced functionality for your browsing experience by setting these cookies. If you reject them, enhanced functionality will be unavailable.

Third-party cookies

Cookies set by third parties may be required to power functionality in conjunction with various service providers for security, analytics, performance or advertising purposes.

Detailed cookie usage

Privacy policy

Reply to thread

We value your privacy