Reply to thread

Message: <blockquote data-quote="Xon" data-source="post: 1530621" data-attributes="member: 71874">Every other location which touches <code class="bbCodeInline">container('reactions')</code> guards against the reaction id being tested against actually exists in the cache. This appears to be the only place which doesn't.This can result in a race condition between a post reaction cache being rebuilt and the reactions container cache being rebuilt.[CODE="php"]if ($scoreField){   $reactionsCache = \XF::app()->container('reactions');   $score = 0;   foreach ($counts AS $reactionId => $count)   {      $reaction = $reactionsCache[$reactionId];      $score += $count * $reaction['reaction_score'];   }[/CODE]This can occur as the content reaction cache is rebuilt when other reactions are used, as it does an raw SQL check against <code class="bbCodeInline">xf_reaction.active</code> column. While the reactions container cache rebuild is punted to after the reaction update transaction.</blockquote>

We value your privacy