Reply to thread

Message

<blockquote data-quote="Xon" data-source="post: 1530621" data-attributes="member: 71874">Every other location which touches [ICODE]container(&#039;reactions&#039;)[/ICODE] guards against the reaction id being tested against actually exists in the cache. This appears to be the only place which doesn&#039;t.This can result in a race condition between a post reaction cache being rebuilt and the reactions container cache being rebuilt.[CODE=&quot;php&quot;]if ($scoreField){&nbsp;&nbsp; $reactionsCache = \XF::app()-&gt;container(&#039;reactions&#039;);&nbsp;&nbsp; $score = 0;&nbsp;&nbsp; foreach ($counts AS $reactionId =&gt; $count)&nbsp;&nbsp; {&nbsp; &nbsp; &nbsp; $reaction = $reactionsCache[$reactionId];&nbsp; &nbsp; &nbsp; $score += $count * $reaction[&#039;reaction_score&#039;];&nbsp;&nbsp; }[/CODE]This can occur as the content reaction cache is rebuilt when other reactions are used, as it does an raw SQL check against [ICODE]xf_reaction.active[/ICODE] column. While the reactions container cache rebuild is punted to after the reaction update transaction.</blockquote>

[QUOTE="Xon, post: 1530621, member: 71874"] Every other location which touches [ICODE]container('reactions')[/ICODE] guards against the reaction id being tested against actually exists in the cache. This appears to be the only place which doesn't. This can result in a race condition between a post reaction cache being rebuilt and the reactions container cache being rebuilt. [CODE="php"]if ($scoreField) { $reactionsCache = \XF::app()->container('reactions'); $score = 0; foreach ($counts AS $reactionId => $count) { $reaction = $reactionsCache[$reactionId]; $score += $count * $reaction['reaction_score']; }[/CODE] This can occur as the content reaction cache is rebuilt when other reactions are used, as it does an raw SQL check against [ICODE]xf_reaction.active[/ICODE] column. While the reactions container cache rebuild is punted to after the reaction update transaction. [/QUOTE]

Verification