Oops.Not worried about it. Money goes to a good dev.
I just might. Creeping your list of features now.Oops.
There should have been a message about a successful purchase. Will be fixed.
Let me know on the site if you wish to change the license to another add-on.
Can you send me the profiling results in DM?Gives slow queries with many attachments in thread.
Fix: optimize DB query to check if thread has attachments, use cached value if Thread Attachment Count add-on installed
Exception: Slow query: 5.2241 seconds, /topics/post-je-maaltijden-met-pics.323275/page-3853 src/addons/SV/SlowQueryLogger/Db/Mysqli/SlowQueryLogAdapter.php:372
Stack trace
#0 src/addons/SV/SlowQueryLogger/Db/Mysqli/SlowQueryLogAdapter.php(159): SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter->{closure:SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter::logQueryCompletion():371}()
#1 src/addons/SV/SlowQueryLogger/Db/Mysqli/SlowQueryLogAdapter.php(371): SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter->withOriginalDbAdapter(Object(Closure))
#2 src/XF/Db/Mysqli/Statement.php(117): SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter->logQueryCompletion()
#3 src/XF/Db/AbstractAdapter.php(96): XF\Db\Mysqli\Statement->execute()
#4 src/XF/Db/AbstractAdapter.php(152): XF\Db\AbstractAdapter->query('
SELECT MAX...', 323275)
#5 src/addons/OzzModz/ThreadAttachmentList/XF/Entity/Thread.php(20): XF\Db\AbstractAdapter->fetchOne('
SELECT MAX...', 323275)
#6 src/XF/Template/Templater.php(1282): OzzModz\ThreadAttachmentList\XF\Entity\Thread->hasAttachments()
#7 internal_data/code_cache/templates/l17/s100/public/thread_view.php(79): XF\Template\Templater->method(Object(SV\SearchImprovements\XF\Entity\ThreadCollab), 'hasAttachments', Array)
#8 src/XF/Template/Templater.php(1092): XF\Template\Templater->{closure:internal_data/code_cache/templates/l17/s100/public/thread_view.php:39}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#9 src/XF/Template/Templater.php(1028): XF\Template\Templater->renderExtensionInternal('thread_action_b...', Array, Array, Object(XF\Template\ExtensionSet))
#10 internal_data/code_cache/templates/l17/s100/public/thread_view.php(648): XF\Template\Templater->renderExtension('thread_action_b...', Array, Object(XF\Template\ExtensionSet))
#11 src/XF/Template/Templater.php(1092): XF\Template\Templater->{closure:internal_data/code_cache/templates/l17/s100/public/thread_view.php:641}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#12 src/XF/Template/Templater.php(1028): XF\Template\Templater->renderExtensionInternal('thread_actions', Array, Array, Object(XF\Template\ExtensionSet))
#13 internal_data/code_cache/templates/l17/s100/public/thread_view.php(1203): XF\Template\Templater->renderExtension('thread_actions', Array, Object(XF\Template\ExtensionSet))
#14 src/XF/Template/Templater.php(1799): XF\Template\Templater->{closure:internal_data/code_cache/templates/l17/s100/public/thread_view.php:946}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet))
#15 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array)
#16 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#17 src/XF/Mvc/Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#18 src/XF/Mvc/Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#19 src/XF/Mvc/Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#20 src/XF/Mvc/Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#21 src/XF/App.php(2824): XF\Mvc\Dispatcher->run()
#22 src/XF.php(806): XF\App->run()
#23 index.php(23): XF::runApp('XF\\Pub\\App')
#24 {main}
Request state
array(4) {
["url"] => string(52) "/threads/..."
["referrer"] => string(55) "/whats-new/latest-activity"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}
[/quote]
- Added caching for thread attachment counts
- Added a thread_id, attach_count index to the xf_post table to improve performance on busy threads and large forums
This update adds caching and indexing for the xf_post columns. This process may require some time and server resources. Therefore, it is not recommended to run the update during periods of high traffic.
Note for large forums:
Added in the latest update counter caching and column indexing to optimize queriesWhen visiting a thread with a large amount of attachments it sometimes still gives slow query (first visits). This is without clicking the attachment link.
Code:Exception: Slow query: 5.2241 seconds, /topics/post-je-maaltijden-met-pics.323275/page-3853 src/addons/SV/SlowQueryLogger/Db/Mysqli/SlowQueryLogAdapter.php:372 Stack trace #0 src/addons/SV/SlowQueryLogger/Db/Mysqli/SlowQueryLogAdapter.php(159): SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter->{closure:SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter::logQueryCompletion():371}() #1 src/addons/SV/SlowQueryLogger/Db/Mysqli/SlowQueryLogAdapter.php(371): SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter->withOriginalDbAdapter(Object(Closure)) #2 src/XF/Db/Mysqli/Statement.php(117): SV\SlowQueryLogger\Db\Mysqli\SlowQueryLogAdapter->logQueryCompletion() #3 src/XF/Db/AbstractAdapter.php(96): XF\Db\Mysqli\Statement->execute() #4 src/XF/Db/AbstractAdapter.php(152): XF\Db\AbstractAdapter->query(' SELECT MAX...', 323275) #5 src/addons/OzzModz/ThreadAttachmentList/XF/Entity/Thread.php(20): XF\Db\AbstractAdapter->fetchOne(' SELECT MAX...', 323275) #6 src/XF/Template/Templater.php(1282): OzzModz\ThreadAttachmentList\XF\Entity\Thread->hasAttachments() #7 internal_data/code_cache/templates/l17/s100/public/thread_view.php(79): XF\Template\Templater->method(Object(SV\SearchImprovements\XF\Entity\ThreadCollab), 'hasAttachments', Array) #8 src/XF/Template/Templater.php(1092): XF\Template\Templater->{closure:internal_data/code_cache/templates/l17/s100/public/thread_view.php:39}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet)) #9 src/XF/Template/Templater.php(1028): XF\Template\Templater->renderExtensionInternal('thread_action_b...', Array, Array, Object(XF\Template\ExtensionSet)) #10 internal_data/code_cache/templates/l17/s100/public/thread_view.php(648): XF\Template\Templater->renderExtension('thread_action_b...', Array, Object(XF\Template\ExtensionSet)) #11 src/XF/Template/Templater.php(1092): XF\Template\Templater->{closure:internal_data/code_cache/templates/l17/s100/public/thread_view.php:641}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet)) #12 src/XF/Template/Templater.php(1028): XF\Template\Templater->renderExtensionInternal('thread_actions', Array, Array, Object(XF\Template\ExtensionSet)) #13 internal_data/code_cache/templates/l17/s100/public/thread_view.php(1203): XF\Template\Templater->renderExtension('thread_actions', Array, Object(XF\Template\ExtensionSet)) #14 src/XF/Template/Templater.php(1799): XF\Template\Templater->{closure:internal_data/code_cache/templates/l17/s100/public/thread_view.php:946}(Object(SV\StandardLib\XF\Template\Templater), Array, Object(XF\Template\ExtensionSet)) #15 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('thread_view', Array) #16 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render() #17 src/XF/Mvc/Dispatcher.php(471): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array) #18 src/XF/Mvc/Dispatcher.php(453): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View)) #19 src/XF/Mvc/Dispatcher.php(412): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View)) #20 src/XF/Mvc/Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html') #21 src/XF/App.php(2824): XF\Mvc\Dispatcher->run() #22 src/XF.php(806): XF\App->run() #23 index.php(23): XF::runApp('XF\\Pub\\App') #24 {main} Request state array(4) { ["url"] => string(52) "/threads/..." ["referrer"] => string(55) "/whats-new/latest-activity" ["_GET"] => array(0) { } ["_POST"] => array(0) { } } [/quote]
Best would be to install this add-on?
Stores cached information about the number of attachments in each thread
But i have already this one installed because i only want to show if first post has attachment.
Displays information about the number attachments in thread first post
Fix: avoid Attempted to convert NULL to integer error when rebuilding attachment counts
We use essential cookies to make this site work, and optional cookies to enhance your experience.