Reply to thread

Message

<blockquote data-quote="Xon" data-source="post: 1543128" data-attributes="member: 71874">For example;[plain][url unfurl=&quot;true&quot; metadata=&quot;O_o123&quot;]example.com[/url][/plain]On edit is rendered as;[plain][url unfurl=&quot;true&quot; metadata=&quot;o_O123&quot;]example.com[/url][/plain]If the simile has multiple mappings, this may result in unexpected (and undesirable) changes to tag&#039;s option data.The issue is in [ICODE]renderUnparsedTag[/ICODE] which uses [ICODE]renderString[/ICODE] without [ICODE]stopSmilies[/ICODE]/[ICODE]plain[/ICODE]/[ICODE]treatAsStructuredText[/ICODE] being set when rendering the tag.[CODE=&quot;php&quot;]public function renderUnparsedTag(array $tag, array $options){&nbsp;&nbsp; return $this-&gt;renderString($tag[&#039;original&#039;][0], $options)&nbsp; &nbsp; &nbsp; . $this-&gt;renderSubTree($tag[&#039;children&#039;], $options)&nbsp; &nbsp; &nbsp; . $this-&gt;renderString($tag[&#039;original&#039;][1], $options);}[/CODE]I think this would work as a fix in [ICODE]EditorHtml::renderUnparsedTag[/ICODE] or [ICODE]Html::renderUnparsedTag[/ICODE];[CODE=&quot;php&quot;]public function renderUnparsedTag(array $tag, array $options){&nbsp;&nbsp; return $this-&gt;renderString($tag[&#039;original&#039;][0], array_merge($options, [&#039;plain&#039; =&gt; true]))&nbsp; &nbsp; &nbsp; . $this-&gt;renderSubTree($tag[&#039;children&#039;], $options)&nbsp; &nbsp; &nbsp; . $this-&gt;renderString($tag[&#039;original&#039;][1], $options);}[/CODE]</blockquote>

[QUOTE="Xon, post: 1543128, member: 71874"] For example; [plain] [url unfurl="true" metadata="O_o123"]example.com[/url] [/plain] On edit is rendered as; [plain] [url unfurl="true" metadata="o_O123"]example.com[/url] [/plain] If the simile has multiple mappings, this may result in unexpected (and undesirable) changes to tag's option data. The issue is in [ICODE]renderUnparsedTag[/ICODE] which uses [ICODE]renderString[/ICODE] without [ICODE]stopSmilies[/ICODE]/[ICODE]plain[/ICODE]/[ICODE]treatAsStructuredText[/ICODE] being set when rendering the tag. [CODE="php"]public function renderUnparsedTag(array $tag, array $options) { return $this->renderString($tag['original'][0], $options) . $this->renderSubTree($tag['children'], $options) . $this->renderString($tag['original'][1], $options); }[/CODE] I think this would work as a fix in [ICODE]EditorHtml::renderUnparsedTag[/ICODE] or [ICODE]Html::renderUnparsedTag[/ICODE]; [CODE="php"]public function renderUnparsedTag(array $tag, array $options) { return $this->renderString($tag['original'][0], array_merge($options, ['plain' => true])) . $this->renderSubTree($tag['children'], $options) . $this->renderString($tag['original'][1], $options); }[/CODE] [/QUOTE]

Verification