[TH] Giphy [Deleted]

[Jake B.]

Should be available now!

 

[mcatze]

Yeah, thanks..

 

[JoyFreak]

When you insert a giphy it immediately adds on the second line.

Suggestion to show what ones you have selected as I was clicking away thinking it wasn't working because the box was covering the text editor. Could maybe also add a 'x' top right to remove it for example.

 

[The Grand Potentate]

the purchase options button in the resource links to a 404

https://www.themehouse.com/xenforo/2/addons/giphy2

are there upgrade options for owners of the v1 addon?

 

[Sebastiaan]

Does this work on mobile phones? Can't add gimpy when im on my iPhone.

 

[Jake B.]

When you insert a giphy it immediately adds on the second line.

Suggestion to show what ones you have selected as I was clicking away thinking it wasn't working because the box was covering the text editor. Could maybe also add a 'x' top right to remove it for example.

I'll look into that and see what we can do

the purchase options button in the resource links to a 404

https://www.themehouse.com/xenforo/2/addons/giphy2

are there upgrade options for owners of the v1 addon?

This should be fixed!

Does this work on mobile phones? Can't add gimpy when im on my iPhone.

It should, yes. What browser/OS are you using?

 

[Sebastiaan]

It should, yes. What browser/OS are you using?

iPhone 7+
iOS 11.2.5
Firefox (latest)
Chrome (latest)
Safari (latest)
Brave (latest)

 

[Jake B.]

Just tested it on my iPhone 7+ and confirmed it's not working. Odd, it was working so something must've gotten changed. Will look into it!

 

[Jake B.]

Turns out that was due to the carousel we're using removing the click event listeners. Have made some adjustments to fix this, as well as a couple of other quality of life improvements

 

[ThemeHouse]

ThemeHouse updated [TH] Giphy with a new update entry:

Version 1.0.1 Patch Level 1 Released

Bugs Fixed:

• Fixes insertion of image on mobile devices
• Giphy now inserts in the location of the cursor instead of at the end of the editor
• Giphy overlay now closes once it's been inserted

Read the rest of this update entry...

 

[Nirjonadda]

Installed but does not showing editor button icon. What need to check for this issue?

 

[Jake B.]

Installed but does not showing editor button icon. What need to check for this issue?

Can you provide a screenshot of what you see, and check your browser's JS console for any errors?

 

[Nirjonadda]

@Jake B. Found this issue, Not compatible with @katsulynx add-on [KL] Editor Manager. Please can be give compatible update? Also bug on next previous button are out of the box. When does not have no more previous/next image then why still showing this button?

 

[Jake B.]

Our editor button is inserted using the standard method for Froala/XenForo, if it doesn't work it's likely to do with an issue within that add-on. Will look into it to see if there is anything we can do, but I can't make any promises.

Also bug on next previous button are out of the box. When does not have no more previous/next image then why still showing this button?

It should continue to load new images. On your screenshot it appears your styling is missing though, as it should look more like this:



Can you check your javascript console for any errors?

 

[Nirjonadda]

Can you check your javascript console for any errors?

Lot of error does this help?

Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: [], removedNodes: […], previousSibling: div.slick-track, nextSibling: img.th_gif.slick-slide, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: [], removedNodes: […], previousSibling: div.slick-track, nextSibling: img.th_gif.slick-slide, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: [], removedNodes: […], previousSibling: div.slick-track, nextSibling: img.th_gif.slick-slide, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: [], removedNodes: […], previousSibling: div.slick-track, nextSibling: img.th_gif.slick-slide, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: [], removedNodes: […], previousSibling: div.slick-track, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.slick-track, addedNodes: […], removedNodes: [], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: […], removedNodes: [], previousSibling: null, nextSibling: div.slick-track, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.th_giphySearchResults.th_giphySlider.slick-initialized.slick-slider, addedNodes: [], removedNodes: […], previousSibling: div.slick-list.draggable, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.slick-list.draggable, addedNodes: […], removedNodes: [], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.formButtonGroup-primary.slickButton, addedNodes: […], removedNodes: [], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: div.formButtonGroup-primary.slickButton, addedNodes: […], removedNodes: [], previousSibling: button.u-jsOnly.button.button--primary.slick-prev.slick-arrow.slick-disabled, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: time.u-dt, addedNodes: [], removedNodes: […], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: time.u-dt, addedNodes: […], removedNodes: [], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: time.u-dt, addedNodes: [], removedNodes: […], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13
Mutation  childList  : 
MutationRecord { type: "childList", target: time.u-dt, addedNodes: […], removedNodes: [], previousSibling: null, nextSibling: null, attributeName: null, attributeNamespace: null, oldValue: null }
content.js:1071:13

 

[kylerc]

@Nirjonadda Can you see if you experience similar issues with the other addon (KL Editor Manager) disabled? It's possible there is a conflict in the styling between both addons. If that doesn't work, go ahead and open a ticket on themehouse.com

 

[Nirjonadda]

@Nirjonadda Can you see if you experience similar issues with the other addon (KL Editor Manager) disabled? It's possible there is a conflict in the styling between both addons. If that doesn't work, go ahead and open a ticket on themehouse.com

KL Editor Manager add-on disabled because showing editor button icon.

 

[Nirjonadda]

@kylerc I have found this issue, there is a conflict in the styling issue from @Siropu Ads Manager 2.

 

[Jake B.]

@kylerc I have found this issue, there is a conflict in the styling issue from @Siropu Ads Manager 2.

That's interesting, I'm not sure what it'd be doing that would cause issues with this. Will contact them to see if we can get a copy of their ad manager add-on to have a look

 

[Nirjonadda]

Our editor button is inserted using the standard method for Froala/XenForo, if it doesn't work it's likely to do with an issue within that add-on. Will look into it to see if there is anything we can do, but I can't make any promises.

Also asking to @katsulynx If can add support on his add-on [KL] Editor Manager?