Fixed Some reaction/like jobs are not transactional

[Xon]

Affected version

2.1.2

A couple of jobs do not appear to call some select+update SQL inside a transaction. This may cause issues if the reads hit a slightly out of date slave instead of the master, as well in some cases leave the user in a weird state if an error occurs

XF\Job\LikeIsCounted & recalculateLikeIsCounted
XF\Job\ReactionIsCounted & recalculateReactionIsCounted
XF\Job\ReactionScore & getUserReactionScore + SQL update

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.5).

Change log:

Wrap a bunch of jobs in transactions so we don't ever find out SELECT results are invalid by the time we UPDATE them

Any changes made as a result of this issue being resolved may not be rolled out here until later.