Reply to thread

Message: <blockquote data-quote="Xon" data-source="post: 1523928" data-attributes="member: 71874">Related to; <a href="https://xenforo.com/community/threads/redundant-io-check-on-loading-phrase-group.195751/" target="_blank">https://xenforo.com/community/threads/redundant-io-check-on-loading-phrase-group.195751/</a>In <code class="bbCodeInline">XF\Template\Templater::getTemplateDataFromSource</code>, there is a <code class="bbCodeInline">file_exists</code> check before an <code class="bbCodeInline">include</code> call, which is redundant;[CODE="php"]protected function getTemplateDataFromSource($type, $name){   $file = $this->getTemplateFilePath($type, $name);   if (!file_exists($file))   {      return false;   }   return include($file);}[/CODE]<code class="bbCodeInline">include</code> returns false on if the file can't be accessed or readable (the warning is converted into an exception by XF), as such the <code class="bbCodeInline">file_exists</code> check is redundant.Rough prototyped replacement;[CODE="php"]protected function getTemplateDataFromSource($type, $name){   $file = $this->getTemplateFilePath($type, $name);   try   {     return include($file);   }   catch (\Throwable $e)   {     return false;   }}[/CODE]</blockquote>

We value your privacy