Fixed Photo can't be uploaded if client side EXIF processing fails unexpectedly

[Kirby]

Affected version

2.3.7

The attached image can't be uploaded on XenForo 2.3.7 (but works fine on 2.3.6 and lower).

This seems to be related to an exception thrown in client side EXIF processing:

case 'GPSTimeStamp':
    value = data.value.map((v) => v.join('/'))
    break

This assumes that v is an array, if it is not it throws an exception.

This exception is caught but silently ignored and the upload is aborted:

try
{
    const result = await this.preProcessFile(file)
    if (result === false)
    {
        throw new Error('File failed pre-processing')
    }
}
catch (e)
{
    this.flow.removeFile(file)
}

There should at least be an error message for the user or (preferred) EXIF processing errors should be ignored and affected tags skipped.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.8).

Change log:

Don't block image upload if EXIF processing fails (#1224)

There may be a delay before changes are rolled out to the XenForo Community.