[XB] XFRM Save Filters [Paid] 2.0.0

[Ozzy47]

Ozzy47 submitted a new resource:

[OzzModz] XFRM Save Filters - Save as default your filters on resource overview page

Save as default your filters on resource overview page.

Note: uses ?saved=true URL param for XFRM navigation item (that automatically added by event listener) to sort items with default filters.

View attachment 249739


Permissions (Resource permissions)
View attachment 249740

Read more about this resource...

 

[Robert9]

There is a fault in:

<?php

namespace PB\XFRMSaveFilters\XFRM\ControllerPlugin;

class Overview extends XFCP_Overview
{
    public function getResourceFilterInput()
    {
        $filters = parent::getResourceFilterInput();

        $visitor = \XF::visitor();

        if ($visitor->user_id && $visitor->hasPermission('resource', 'pb_xfrmsf_canUse'))
        {
            $filterRepo = $this->getFilterDefaultRepo();

            if ($this->filter('save', 'bool') && $this->isPost())
            {
                $filterRepo->saveUserDefaultFilters($visitor, $filters);
            }

            //if (!$filters && $this->filter('saved', 'bool'))
            if (!$filters)
            {
                $filters = $filterRepo->getUserDefaultFilters($visitor);
            }
        }

        return $filters;
    }

Now it works only on overview.
But with if (!$filters) instead if (!$filters && $this->filter('saved', 'bool'))
it works also on cats.

 

[Robert9]

The problem is probably here:

    public static function navigationSetup(\XF\Pub\App $app, array &$navigationFlat, array &$navigationTree)
    {
        $visitor = \XF::visitor();
        if ($visitor->user_id && $visitor->hasPermission('resource', 'pb_xfrmsf_canUse') && isset($navigationFlat['xfrm']) && isset($navigationTree['xfrm']))
        {
            $resourceLink = $app->router('public')->buildLink('resources', null, ['saved' => true]);
            $navigationFlat['xfrm']['href'] = $resourceLink;
            $navigationTree['xfrm']['href'] = $resourceLink;
        }
    }

fits for overview and cats
if ($visitor->user_id && $visitor->hasPermission('resource', 'pb_xfrmsf_canUse') && isset($navigationFlat['xfrm']) && isset($navigationTree['xfrm']))


fits for overview only?
$resourceLink = $app->router('public')->buildLink('resources', null, ['saved' => true]);


How we can decide, if we are in a cat or have the catId to change the $resourceLink, please?

 

[Robert9]

Hmmm
navigationSetup
is used for every page we have, right?

but we need that only for p/c/resourceitem > actionIndex without a resoure_id
and for p/c/category > actionIndex ?

also
if (!$filters && $this->filter('saved', 'bool'))

could mean that we have some_filters (from another addon for example), but not what we have saved?

 

[Ozzy47]

Ozzy47 updated [OzzModz] XFRM Save Filters with a new update entry:

[OzzModz] XFRM Save Filters for XenForo 2.2 Update 1.0.0 Patch Level 1

Added missing template modification for "categories" links (should add "saved" URL param)

Read the rest of this update entry...

 

[Robert9]

Oops! We ran into some problems.
File does not exist

 

[Ozzy47]

Should be fixed.

 

[Ozzy47]

Ozzy47 updated [OzzModz] XFRM Save Filters with a new update entry:

[OzzModz] XFRM Save Filters for XenForo 2.2+ Update 2.0.0

2.0.0
XF 2.2 and 2.3 compatibility

Read the rest of this update entry...