Oblivion Knight
Well-known member
Agreed. It was more of a throwaway suggestion 'in an ideal world' kind of scenario..
It appears the above is as designed. Even if I have four stickies, numbered 1 - 4, and I stick a new thread with a order of 15, the actual orded number ends up being 5.
public function fetchSequencesByIds(array $ids)
{
if (!$ids)
{
return $this->em->getEmptyCollection();
}
function sortOrder($a, $b)
{
if ($a == $b)
{
return 0;
}
return ($a < $b) ? -1 : 1;
}
$sequences = $this->em->findByIds('Bespoke\SequentialStickies:Sequence', $ids)->toArray();
usort($sequences, function ($a, $b) { return sortOrder($a['sequence_order'], $b['sequence_order']); });
return $sequences;
}
Fixed: I’ve created 10+ stickies and it does not save it as the number I entered, like if I have 11 stickies already, and set a new one as 12, it actually saves it as 5 (or some random number), which is really odd.
Fatal error: Cannot redeclare Bespoke\SequentialStickies\Repository\sortOrder() (previously declared in /home/edewan/public_html/forum/src/addons/Bespoke/SequentialStickies/Repository/Sequence.php:31) in /home/edewan/public_html/forum/src/addons/Bespoke/SequentialStickies/Repository/Sequence.php on line 31
Potential fix for, Fatal error: Cannot redeclare Bespoke\SequentialStickies\Repository\sortOrder() (previously declared in /home/edewan/public_html/forum/src/addons/Bespoke/SequentialStickies/Repository/Sequence.php:31) in /home/******/public_html/forum/src/addons/Bespoke/SequentialStickies/Repository/Sequence.php on line 31
When use forum view filter and apply "sort by" option.
XenForo 2.2.6
#0 src/addons/Bespoke/SequentialStickies/Listener.php(78): XF\Mvc\Entity\Entity->getPreviousValue('node_id')
#1 src/XF/Extension.php(52): Bespoke\SequentialStickies\Listener::threadEntityPostSave(Object(Bespoke\SequentialStickies\Entity\Sequence))
#2 src/XF.php(966): XF\Extension->fire('entity_post_sav...', Array, 'XF\\Entity\\Threa...')
#3 src/XF/Mvc/Entity/Entity.php(1276): XF::fire('entity_post_sav...', Array, 'XF\\Entity\\Threa...')
#4 src/XF/Service/Thread/Mover.php(116): XF\Mvc\Entity\Entity->save(true, false)
#5 src/XF/Pub/Controller/Thread.php(1236): XF\Service\Thread\Mover->move(Object(XFMG\XF\Entity\Forum))
#6 src/XF/Mvc/Dispatcher.php(352): XF\Pub\Controller\Thread->actionMove(Object(XF\Mvc\ParameterBag))
#7 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XF:Thread', 'Move', Object(XF\Mvc\RouteMatch), Object(SV\AlertImprovements\XF\Pub\Controller\Thread), NULL)
#8 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(SV\AlertImprovements\XF\Pub\Controller\Thread), NULL)
#9 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#10 src/XF/App.php(2352): XF\Mvc\Dispatcher->run()
#11 src/XF.php(524): XF\App->run()
#12 index.php(20): XF::runApp('XF\\Pub\\App')
#13 {main}
array(4) {
["url"] => string(9) "/faq/move"
["referrer"] => string(30) "https://mesozoichaven.com/faq/"
["_GET"] => array(0) {
}
["_POST"] => array(9) {
["_xfToken"] => string(8) "********"
["prefix_id"] => string(1) "0"
["title"] => string(26) "Frequently Asked Questions"
["target_node_id"] => string(2) "44"
["redirect_type"] => string(9) "permanent"
["notify_watchers"] => string(1) "1"
["_xfRequestUri"] => string(5) "/faq/"
["_xfWithData"] => string(1) "1"
["_xfResponseType"] => string(4) "json"
}
}
2.0.1 Patch Level 2:
- Fixed overriding entity variable in thread entity_post_save listener
We use essential cookies to make this site work, and optional cookies to enhance your experience.