sbj
Well-known member
The new feature works well and almost all tests I could think of went perfectly. But at the end I found one bug with it.
Say we have a badge with user criteria active and where the "is recallable" option is active.
Automatically after the cron runs all works perfectly. Badge is given or taken, just like we expect. New feature works.
But if we award same badge manually to someone, then user criteria is never respected anymore. It overrides user criteria and we can't never reset it. We can only manually award or take away. When cron runs nothing happens anymore.
In general it makes no sense to award manually badges with criteria and "is recallable" because we have set criteria for a reason. We shouldn't have put criteria for it if we wanted to award manually.
So, the solution is that badges with user criteria and "is recallable" option checked should not be in the list for awarding manually. Because user criteria will take care of it. No need to award manually for those badges. But in the settings if those options are unchecked, now they should be again in the list for awarding manually.
With manual awarding I mean this:

edit:
If

then

----
If

and

then

Say we have a badge with user criteria active and where the "is recallable" option is active.
Automatically after the cron runs all works perfectly. Badge is given or taken, just like we expect. New feature works.
But if we award same badge manually to someone, then user criteria is never respected anymore. It overrides user criteria and we can't never reset it. We can only manually award or take away. When cron runs nothing happens anymore.
In general it makes no sense to award manually badges with criteria and "is recallable" because we have set criteria for a reason. We shouldn't have put criteria for it if we wanted to award manually.
So, the solution is that badges with user criteria and "is recallable" option checked should not be in the list for awarding manually. Because user criteria will take care of it. No need to award manually for those badges. But in the settings if those options are unchecked, now they should be again in the list for awarding manually.
With manual awarding I mean this:

edit:
If

then

----
If

and

then

Last edited: